Skip to content

chore: bump rust-dashcore to commit 383b306e4438e21852aea5762f4aedda9549acd4#3486

Open
ZocoLini wants to merge 1 commit intov3.1-devfrom
chore/bump-rust-dashcore
Open

chore: bump rust-dashcore to commit 383b306e4438e21852aea5762f4aedda9549acd4#3486
ZocoLini wants to merge 1 commit intov3.1-devfrom
chore/bump-rust-dashcore

Conversation

@ZocoLini
Copy link
Copy Markdown
Collaborator

@ZocoLini ZocoLini commented Apr 13, 2026

Some changes in the FFI are coming soon so I would like to bump the version before those changes with the latest changes available. With this version bump we are getting:

  • fix: SPVClient stalling issues
  • chore: Reduced static library size used in rust-dashcore by 4MB aprox. (not a lot but looks like removing unused dependencies had some impact)
  • fix: SPVClient announcing tip to new peers when synced
  • fix: suscribe to SPVClient event monitors before startup

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Summary by CodeRabbit

  • Chores
    • Updated multiple workspace dependencies to their latest versions.

@ZocoLini ZocoLini marked this pull request as ready for review April 13, 2026 16:43
@github-actions github-actions bot added this to the v3.1.0 milestone Apr 13, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 62cd182c-5d5b-4362-b258-f20835150937

📥 Commits

Reviewing files that changed from the base of the PR and between c061bd4 and f1a9218.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • Cargo.toml

📝 Walkthrough

Walkthrough

Updated Git revision hashes for seven shared workspace dependencies sourced from the rust-dashcore repository: dashcore, dash-spv, dash-spv-ffi, key-wallet, key-wallet-ffi, key-wallet-manager, and dashcore-rpc. Only the rev field values were modified in Cargo.toml; no other configuration was changed.

Changes

Cohort / File(s) Summary
Workspace Dependency Revisions
Cargo.toml
Updated Git rev for seven rust-dashcore workspace dependencies to newer commits.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • QuantumExplorer

Poem

🐰 A hop, a skip, through dependency lanes,
The revisions dance, in code's refrain,
Dashcore and friends now point ahead,
To fresher commits, newly fed! 🎯✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: bumping rust-dashcore dependencies to a specific commit hash, which aligns with the changeset that updates Git revisions for all rust-dashcore-related workspace dependencies.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/bump-rust-dashcore

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thepastaclaw
Copy link
Copy Markdown
Collaborator

thepastaclaw commented Apr 13, 2026

✅ Review complete (commit f1a9218)

Copy link
Copy Markdown
Collaborator

@thepastaclaw thepastaclaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Clean dependency bump of rust-dashcore from rev 88e8a9aa to 383b306e. Only Cargo.toml (7 consistent rev pin updates) and the auto-generated Cargo.lock are modified. No platform source code changes. Upstream changes include dependency cleanup, log-to-tracing migration, and SPV bug fixes — none affect platform's usage of these crates.

Reviewed commit: f1a9218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants