feat: add managed_core_account_set_transaction_label FFI function#618
feat: add managed_core_account_set_transaction_label FFI function#618xdustinface wants to merge 2 commits intov0.42-devfrom
managed_core_account_set_transaction_label FFI function#618Conversation
Just to avoid having huge data stored in the labels and i think 256 chars should be more than enough for a transaction label.
Add mutable access to `FFIManagedCoreAccount` via `inner_mut()` and expose a function to set or clear transaction labels by txid. Also add comprehensive tests for: - `managed_core_account_get_transactions` with real transaction data - `managed_core_account_free_transactions` verifying no crash on free - Label round-trip (set, read back, clear, verify cleared) - Error cases (null account, missing txid)
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v0.42-dev #618 +/- ##
=============================================
+ Coverage 67.21% 67.69% +0.47%
=============================================
Files 321 321
Lines 68249 68523 +274
=============================================
+ Hits 45874 46384 +510
+ Misses 22375 22139 -236
|
|
This PR has merge conflicts with the base branch. Please rebase or merge the base branch into your branch to resolve them. |
Add mutable access to
FFIManagedCoreAccountviainner_mut()and expose a function to set or clear transaction labels by txid.Also add comprehensive tests for:
managed_core_account_get_transactionswith real transaction datamanaged_core_account_free_transactionsverifying no crash on freeBased on: