Add X-Databricks-Org-Id header to Shares.list() extension for SPOG hosts#761
Open
simonfaltum wants to merge 1 commit intomainfrom
Open
Add X-Databricks-Org-Id header to Shares.list() extension for SPOG hosts#761simonfaltum wants to merge 1 commit intomainfrom
simonfaltum wants to merge 1 commit intomainfrom
Conversation
…st compatibility The hand-written SharesExtImpl.list() makes a direct apiClient.execute() call without the X-Databricks-Org-Id header that SPOG hosts require for routing. The generated service implementations already include this header per-call, but this extension was missing it. Co-authored-by: Isaac
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Contributor
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
simonfaltum
had a problem deploying
to
test-trigger-is
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Hand-written extension methods that make direct
apiClient.execute()calls are missing theX-Databricks-Org-Idheader that SPOG hosts require for routing. The generated service implementations already include this header per-call, butSharesExtImpl.list()was missing it.Linked Go SDK PR: databricks/databricks-sdk-go#1634
Changes
Added the
X-Databricks-Org-Idheader toSharesExtImpl.list(), matching the pattern used by generated code:Test plan
mvn compile -pl databricks-sdk-javapassesThis pull request was AI-assisted by Isaac.