Open
Conversation
This file has not been touched substantively in a few years, is not
documented, and no longer works.
If these missing dependencies are added to pyproject.toml:
* ipython-sql
* sql
Then the user can do the following in a notebook/console started from
the mycli repo root:
In [1]: %load_ext sql
In [2]: %load_ext mycli.magic
In [3]: %sql mysql+pymysql://mycli:password@localhost:3306/mysql
However, upon executing a query with the magic
In [4]: %mycli show tables
we find that magic.py has
mycli: MyCli = conn._mycli
but mycli has long since been refactored, such that
AttributeError: 'Connection' object has no attribute '_mycli'
and it throws similarly for
u = conn.session.engine.url
Given that this is not working, not maintained, and not documented, we
should be comfortable deleting it without a deprecation cycle.
In the future, if this functionality is desired, it should probably be
implemented in a separate library which takes mycli as a dependency.
That way it could be more discoverable on PyPi, and could declare
additional dependencies needed only in the notebook context.
d0b3ee1 to
2af0ecf
Compare
scottnemes
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This file has not been touched substantively in a few years, is not documented, and no longer works.
If these missing dependencies are added to
pyproject.toml:Then the user can do the following in a notebook/console started from the mycli repo root:
However, upon executing a query with the magic
we find that
magic.pyhasbut mycli has long since been refactored, such that
and it throws similarly for
Given that this is not working, not maintained, and not documented, we should be comfortable deleting it without a deprecation cycle.
In the future, if this functionality is desired, it should probably be implemented in a separate library which takes mycli as a dependency. That way it could be more discoverable on PyPi, and could declare additional dependencies needed only in the notebook context.
Side note: this file was not covered by tests, and removing it brings the repo to 100% coverage.
Checklist
changelog.mdfile.AUTHORSfile (or it's already there).