Skip to content

fix: preserve hash character in pg_service.conf passwords #1578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bobo-xxx wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

fix: preserve hash character in pg_service.conf passwords #1578

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pgcli/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1974,7 +1974,7 @@ def parse_service_info(service):
with open(service_file, newline="") as f:
skipped_lines = skip_initial_comment(f)
try:
service_file_config = ConfigObj(f)
service_file_config = ConfigObj(f, comment_tokens=[])
Copy link

Copilot AI Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s test coverage for service-file parsing (test_pg_service_file), but it doesn’t cover the regression fixed here (passwords containing #). Please extend/add a test case with password=abc#123 (and ideally one with a trailing comment after the value) to ensure the password is preserved and comment handling remains correct.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting comment_tokens=[] disables all #/; comment parsing for the entire .pg_service.conf. That will likely break valid service files that contain full-line comments after the first section header (those # ... lines would no longer be treated as comments and can trigger a parse error). Consider using a parser/configuration that keeps full-line comments but disables inline comment parsing (e.g., a ConfigParser setup with inline_comment_prefixes=() while retaining comment_prefixes, or another ConfigObj option that only disables inline comments).

Copilot uses AI. Check for mistakes.
except ParseError as err:
err.line_number += skipped_lines
raise err
Expand Down
Loading