Skip to content

Fix silent no-op in Queue::addJob when task does not queue a job #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dereuromark merged 1 commit into from
Apr 22, 2026
Merged

Fix silent no-op in Queue::addJob when task does not queue a job #478

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/Controller/Admin/QueueController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,13 +133,27 @@ public function addJob() {
}

$object = new $className();
// Measure the QueuedJobs count before invoking the task so we can
// tell whether the task actually queued a job. AddInterface::add()
// returns void and may silently no-op when required config is
// missing (e.g. EmailTask without Config.adminEmail). Without this
// check the controller would falsely report success.
$before = $this->QueuedJobs->find()->count();
if ($object instanceof AddInterface) {
$object->add(null);
} else {
$this->QueuedJobs->createJob($job);
}
$after = $this->QueuedJobs->find()->count();

$this->Flash->success('Job ' . $job . ' added');
if ($after > $before) {
$this->Flash->success('Job ' . $job . ' added');
} else {
$this->Flash->error(
'Job ' . $job . ' could not be added — the task did not create a job. '
. 'Check configuration (e.g. Config.adminEmail for Queue.Email) and server logs.',
);
}

return $this->refererRedirect(['action' => 'index']);
}
Expand Down
Loading