Skip to content

fix: improve click handling for injected components in ThreeDotsMenu #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kulikp1 wants to merge 2 commits into
base: next
Choose a base branch
from
Open

fix: improve click handling for injected components in ThreeDotsMenu #538

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a939b2
fix: improve click handling for injected components in ThreeDotsMenu
kulikp1 Apr 6, 2026
8ecde17
fix: improve click handling for injected components in ThreeDotsMenu
kulikp1 Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions adminforth/spa/src/components/ThreeDotsMenu.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
'opacity-50': checkboxes && checkboxes.length === 0 && item.meta?.disabledWhenNoCheckboxes,
'cursor-not-allowed': checkboxes && checkboxes.length === 0 && item.meta?.disabledWhenNoCheckboxes,
}"
@click="injectedComponentClick(i)"
@click="injectedComponentClick($event, i)"
>
<div class="wrapper" v-if="getCustomComponent(item)">
<component
Expand Down Expand Up @@ -172,10 +172,16 @@ function startBulkAction(actionId: string) {
showDropdown.value = false;
}

async function injectedComponentClick(index: number) {
function injectedComponentClick(e: MouseEvent, index: number) {
if (!e.isTrusted) return;

const componentRef = threeDotsDropdownItemsRefs.value[index];
if (componentRef && 'click' in componentRef) {
(componentRef as any).click?.();
if (componentRef) {
if (typeof (componentRef as any).click === 'function') {
(componentRef as any).click();
} else if (componentRef.$el && typeof componentRef.$el.click === 'function') {
componentRef.$el.click();
}
Comment on lines +180 to +184
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling componentRef.$el.click() from within the parent @click handler can synchronously dispatch a new click event that bubbles back to this same handler, potentially causing recursive re-entry (and double-triggering actions). Consider adding a re-entrancy guard (e.g., ignore non-user-triggered events via event.isTrusted / a local flag) or dispatch a non-bubbling event / trigger a more direct component method so the synthetic click doesn’t re-invoke injectedComponentClick.

Copilot uses AI. Check for mistakes.
}
showDropdown.value = false;
}
Expand Down