fix: Try not to fail when comparing different types [DHIS2-21115]

[enricocolasante]

Fix equality operator coercion for mixed types

Changes

BinaryOperator.equal — Reworked the type coercion priority for the == and != operators:

• Number takes priority over Boolean: when either operand is a Number, both sides are coerced to numbers before comparing. This aligns with JavaScript == semantics — true becomes 1.0, false becomes 0.0, so 1 == true is true but 2 == true is false.
• Non-numeric strings no longer throw: comparing a number with a string that cannot be parsed as a number (e.g. '', 'hello') now returns false instead of throwing a NumberFormatException. This is handled by the new tryToNumber helper.
• Boolean+String fallback: when neither operand is a number, the boolean coercion path applies. Strings are coerced via String.toBoolean(), meaning any string other than "true" (case-insensitive) is treated as false.

Removed behaviour

• 2.1 == false previously threw IllegalArgumentException: Could not coerce Double '2.1' to Boolean. It now returns false, since the number path takes priority and 2.1 != 0.0.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[jbee]

I was thinking for some time that always making a numeric comparison if one side is a number is not fully correct as you might miss that coercion to what the other side might want to be might be successful but I think it does work because any type where that would make a difference can be coerced to a number so doing it that way around comes out the same.