Conversation
|
Claude finished @zJaaal's task in 3m 9s —— View job PR Review
Three issues worth a second look: 1. Memoization skip for no-permission folders ( When 2. Unrelated changes in Two 3. JSP: no server-side The new JSP loads the permissions portlet for any authenticated user who can Everything else looks clean: |
- Derive PermissionType union from PERMISSIONS_TYPE const and narrow DotContentDriveFolder.permissions from string[] to PermissionType[] - Replace .find() with .includes() for permission checks in context menu - Add test for folder with empty permissions yielding zero menu items Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…-when-editing-folders
…ng-folders' of https://github.com/dotCMS/core into 35160-task-content-drive-add-permissions-tab-when-editing-folders
Summary
EDIT_PERMISSIONSpermission on the folderDotPermissionsIframeDialogComponentloading/html/portlet/ext/folders/permissions.jspin an iframepermissions.jspto serve the existing permissions portlet in popup mode for folderspermissionsfield inDotContentDriveFolderfromnumber[]tostring[]and addedPERMISSIONS_TYPEconst enumPage {currentPage}) in folder list view paginationTest plan
EDIT_PERMISSIONS— verify Edit Permissions appears in the context menuEDIT_PERMISSIONS— verify the option is absentyarn nx test dot-content-drive🤖 Generated with Claude Code
This PR fixes: #35160
This PR fixes: #35160