Fix timeout catch in HTTP LoggingHandler and add tests to verify#2072
Draft
lbussell wants to merge 5 commits intodotnet:mainfrom
Draft
Fix timeout catch in HTTP LoggingHandler and add tests to verify#2072lbussell wants to merge 5 commits intodotnet:mainfrom
lbussell wants to merge 5 commits intodotnet:mainfrom
Conversation
The LoggingHandler timeout catch clause never fired because HttpClient passes a linked CancellationToken (user token + timeout token) to DelegatingHandler.SendAsync. When a timeout occurs, the linked token is already cancelled, so the 'when (!cancellationToken.IsCancellationRequested)' guard evaluated to false and the catch was skipped entirely. Fix by catching OperationCanceledException and checking for TimeoutException as InnerException to distinguish timeouts from caller-driven cancellations. Also add a pre-request Debug log so hanging requests are visible, and restore the pre-fetch log in GetReferrersAsync for non-dry-run calls. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Extract LoggingHandler as a public class (this is an exe, not a library, so public visibility has no external impact) with a testable constructor that accepts ILogger directly. Tests verify: - Timeout (TaskCanceledException with TimeoutException inner) logs 'HTTP timeout' at Warning level - Caller cancellation (OperationCanceledException without TimeoutException) logs 'HTTP canceled' at Warning level, not 'HTTP timeout' Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
lbussell
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow up from #2071.
The
LoggingHandlertimeout catch clause never fired because HttpClient passes a linked CancellationToken (user token + timeout token) toDelegatingHandler.SendAsync. When a timeout occurs, the linked token is already cancelled, so thewhen (!cancellationToken.IsCancellationRequested)guard evaluated to false and the catch was skipped entirely.