Add failure label to "AutoBuilder - Failed" notifications for recent build failures#2093
Draft
Add failure label to "AutoBuilder - Failed" notifications for recent build failures#2093
Conversation
…ild failures The failure label was only added when an exception was thrown, not when the category was 'Failed' due to recent build failures. This caused these actionable issues to be immediately closed by NotificationService. Change the condition from `exception is not null` to `category == "Failed"` so both failure paths (exception and recent failed builds) get the failure label and remain open. Agent-Logs-Url: https://github.com/dotnet/docker-tools/sessions/89cbb121-4c87-422e-83ec-09a65bd377c6 Co-authored-by: lbussell <36081148+lbussell@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix NotificationService to leave 'AutoBuilder - Failed' issues open
Add failure label to "AutoBuilder - Failed" notifications for recent build failures
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NotificationServiceimmediately closes any issue without thefailurelabel.QueueBuildCommandonly added this label on exceptions, not when the category was "Failed" due to recent build failures — so "AutoBuilder - Failed" issues were created and immediately closed.Changes
QueueBuildCommand.cs: Changed theAppendIfcondition fromexception is not nulltocategory == "Failed", which covers both failure paths (exceptions and recent build failures):QueueBuildCommandTests.cs: AddedQueueBuildCommand_RecentFailedBuilds_IncludesFailureLabeltest and aVerifyNotificationLabelsContainhelper onTestContext.