Conversation
The GC pipeline has been broken for some time, failing with `[error]No image label found to route agent pool Azure Pipelines`
janvorli
added
the
gc-infrastructure
There was a problem hiding this comment.
Pull request overview
This PR updates the GC Azure Pipelines configuration to address a long-standing agent routing failure (No image label found to route agent pool Azure Pipelines) by changing the Windows hosted image label used for the GC notebook validation job.
Changes:
- Update the Windows job pool image from
windows-2019towindows-2025.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| bdnProcess.Start(); | ||
| string traceName = $"{benchmarkCleanedName}_{index}"; | ||
| using (TraceCollector traceCollector = new TraceCollector(traceName, collectType, runPath)) | ||
| using (TraceCollector traceCollector = new TraceCollector(traceName, collectType, runPath, bdnProcess.Id)) | ||
| { | ||
| bdnProcess.Start(); | ||
| bdnProcess.BeginOutputReadLine(); |
There was a problem hiding this comment.
Trace collection ordering is now reversed (process starts before TraceCollector). On Windows TraceCollector starts PerfView immediately in its constructor and does not attach to a specific PID, so starting the benchmark process first can miss early ETW events (and diverges from the Windows pattern used in GCPerfSimCommand). Consider branching by OS: on Windows, create TraceCollector (without pid) before starting the benchmark process; on Linux, start the process first and pass its pid to TraceCollector (required).
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - task: UseDotNet@2 | ||
| displayName: Install .NET 11.0 | ||
| inputs: | ||
| version: 11.0.x | ||
| includePreviewVersions: true |
There was a problem hiding this comment.
The comment above these steps says the job “temporarily need[s] both .NET 8 … and .NET 9”, but the pipeline now installs 8/9/10/11. Please update that comment to match the actual SDK requirements (or drop any unneeded installs) so future maintainers don’t remove a required SDK by mistake.
The GC pipeline has been broken for some time, failing with
[error]No image label found to route agent pool Azure Pipelines