Skip to content

chore(workflows): minor cleanups — env vars, silent rebase, duplicate RSS (#65)#66

Open
madjin wants to merge 1 commit intomainfrom
fix/issue-6-workflow-cleanups
Open

chore(workflows): minor cleanups — env vars, silent rebase, duplicate RSS (#65)#66
madjin wants to merge 1 commit intomainfrom
fix/issue-6-workflow-cleanups

Conversation

@madjin
Copy link
Copy Markdown
Contributor

@madjin madjin commented Apr 18, 2026

Fixes #65.

Summary

Five low-risk cleanups bundled:

# File Change
1 daily_discord_briefing.yml Hardcoded channel ID → vars.DISCORD_FACTS_CHANNEL_ID (fallback to current value)
2 generate-council-briefing.yml Remove duplicate generate-rss.py call; generate-posters.yml runs it later
3 update_hackmd_notes.yml Rebase conflict fails loud instead of continuing silently
4 aggregate-daily-sources.yml Drop unused GITHUB_TOKEN env on script step
5 sync.yml Commit message drops literal $(date +%Y-%m-%d) (not shell-evaluated by git-auto-commit-action)

Test plan

  • YAML parse all 5 modified files
  • After merge: vars.DISCORD_FACTS_CHANNEL_ID can be set in repo settings → Variables to override without editing the workflow (optional — default matches current hardcoded value)

🤖 Generated with Claude Code

… RSS

Five small cleanups bundled:

1. daily_discord_briefing.yml — hardcoded Discord channel ID moves to a
   workflow-level env reading vars.DISCORD_FACTS_CHANNEL_ID (with the
   current value as fallback for zero-downtime migration).
2. generate-council-briefing.yml — drop duplicate generate-rss.py call;
   generate-posters.yml already runs it later with richer data.
3. update_hackmd_notes.yml — rebase conflict now fails loud instead of
   aborting silently and continuing. Old pattern made conflicts produce
   obscure failures two steps later at commit time.
4. aggregate-daily-sources.yml — drop unused GITHUB_TOKEN env on
   aggregate-sources.py (script comment already flagged it as unused).
5. sync.yml — commit_message dropped literal "$(date +%Y-%m-%d)" which
   git-auto-commit-action doesn't shell-evaluate. Commit timestamp
   already encodes the date.

Fixes #65

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 18, 2026

Warning

Rate limit exceeded

@madjin has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 34 minutes and 26 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 34 minutes and 26 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f4e4db03-79f2-4b77-8034-4c7fecb404ee

📥 Commits

Reviewing files that changed from the base of the PR and between e4fac34 and a98ca0c.

📒 Files selected for processing (5)
  • .github/workflows/aggregate-daily-sources.yml
  • .github/workflows/daily_discord_briefing.yml
  • .github/workflows/generate-council-briefing.yml
  • .github/workflows/sync.yml
  • .github/workflows/update_hackmd_notes.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/issue-6-workflow-cleanups

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@madjin
Copy link
Copy Markdown
Contributor Author

madjin commented Apr 18, 2026

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 18, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Minor workflow cleanups: hardcoded IDs, duplicate RSS, silent rebase, unused env vars, literal $(date)

1 participant