test: add more e2e tests in options.test.ts#375
Merged
Conversation
✅ Deploy Preview for eslint-code-explorer ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR expands Playwright E2E coverage for the Language Options popover, adding assertions for JavaScript language options and strengthening checks for the existing language option panels.
Changes:
- Refactors
e2e-tests/options.test.tsinto clearly labeledtest.stepblocks per language. - Adds assertions for JavaScript option controls (Parser, Source Type, ECMAScript Version, JSX).
- Expands existing language checks to validate the selected language and key default option values.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lumirlumir
changed the title
options.test.tsoptions.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request?
While working on #299, I found that the
options.test.tse2e test was missing some cases because it only verifies the basic portion of the options UI. I added more test cases to ensure JavaScript language options and other UI elements are also covered.To make the test sequence clearer and avoid breaking the current test structure, I used
test.step. I've also added theexact: trueoption when checking thename, since it makes the test stricter, as mentioned below:What changes did you make? (Give an overview)
This PR add more tests in
options.test.ts.Related Issues
N/A
Is there anything you'd like reviewers to focus on?
N/A