Skip to content

fix: datastore integration text taxonomy [ENG-3209]#7943

Merged
speaker-ender merged 2 commits intomainfrom
fix/database-integration-text-taxonomy--ENG-3209
Apr 16, 2026
Merged

fix: datastore integration text taxonomy [ENG-3209]#7943
speaker-ender merged 2 commits intomainfrom
fix/database-integration-text-taxonomy--ENG-3209

Conversation

@speaker-ender
Copy link
Copy Markdown
Contributor

@speaker-ender speaker-ender commented Apr 16, 2026

Ticket ENG-3209

Description Of Changes

Changes the taxonomy of the datastore monitor content based on the type of monitor being created/edited.

Code Changes

Steps to Confirm

  1. Add a bigquery integration
  2. Add a monitor to that integration and confirm that the second modal refers to the selectable content as projects
  3. Add any other type of datastore integration
  4. Add a monitor to that integration and confirm that the second modal refers to the selectable content as databases

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Apr 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Apr 16, 2026 4:52pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Apr 16, 2026 4:52pm

Request Review

@speaker-ender speaker-ender force-pushed the fix/database-integration-text-taxonomy--ENG-3209 branch from 33d78b6 to fc38e0c Compare April 16, 2026 14:30
@speaker-ender speaker-ender changed the title fix: database integration text taxonomy [ENG-3209] fix: datastore integration text taxonomy [ENG-3209] Apr 16, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 16, 2026

Title Lines Statements Branches Functions
admin-ui Coverage: 8%
6.17% (2707/43826) 5.37% (1337/24866) 4.24% (550/12964)
fides-js Coverage: 78%
78.98% (1962/2484) 65.55% (1214/1852) 72.57% (336/463)
privacy-center Coverage: 88%
85.97% (331/385) 81.36% (179/220) 78.87% (56/71)

chore: update changelog

fix: missing commit

chore: linting
@speaker-ender speaker-ender force-pushed the fix/database-integration-text-taxonomy--ENG-3209 branch from fc38e0c to 166cbac Compare April 16, 2026 15:44
@speaker-ender speaker-ender marked this pull request as ready for review April 16, 2026 16:41
@speaker-ender speaker-ender requested a review from a team as a code owner April 16, 2026 16:41
@speaker-ender speaker-ender requested review from jpople and removed request for a team April 16, 2026 16:41
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review: PR #7943 — Datastore integration text taxonomy

The change is clean and correctly addresses the problem: the UI was hardcoded to BigQuery terminology ("projects") even for non-BigQuery integrations. The as const narrowing on DATASTORE_CONTENT_TAXONOMY produces exact literal tuple types, and the prop typing with readonly [string, string] is a good fit.

Summary of findings

Default value bias (minor)ConfigureMonitorDatabasesForm defaults to ["project", "projects"] which is BigQuery-specific. Since ConfigureMonitorModal always supplies the prop now, this only affects standalone usage, but it's a surprising default. Prefer a neutral fallback or make the prop required. See inline comment.

Scalability of the BIGQUERY check (minor) — The connection_type === ConnectionType.BIGQUERY conditional works for the current two-way split but may need to grow as more integration types are onboarded (Snowflake, Redshift, MongoDB, etc. all could have distinct preferred terminology). Keying DATASTORE_CONTENT_TAXONOMY directly off ConnectionType values would keep future additions in one place. See inline comment with a concrete pattern.

No tests — Neither component has existing test coverage, so there's no regression, but adding a basic snapshot or render test for the new contentTaxonomy prop (verifying both "project" and "database" variants render the correct strings) would guard against future copy changes.

What looks good

  • as const + readonly [string, string] is properly type-safe.
  • Template literals are consistently applied across all three text sites (header, tooltip, and save-disabled tooltip).
  • The old TOOLTIP_COPY constant (hardcoded "project") is cleanly removed — no dead code left behind.
  • Changelog entry is present.

Overall this is a straightforward, low-risk fix. The two inline comments are suggestions, not blockers.


🔬 Codegraph: connected (46795 nodes)


💡 Write /code-review in a comment to re-run this review.

@speaker-ender speaker-ender added this pull request to the merge queue Apr 16, 2026
Merged via the queue into main with commit c2debbc Apr 16, 2026
51 checks passed
@speaker-ender speaker-ender deleted the fix/database-integration-text-taxonomy--ENG-3209 branch April 16, 2026 18:07
@claude claude bot mentioned this pull request Apr 17, 2026
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants