Merged
Conversation
DotLYHiyou
approved these changes
Feb 27, 2026
Member
|
@DotLYHiyou - we don't accept reviews or contributions from non-mainatiners/long-term contributors on this repo. Thanks. |
Member
|
@colinleach - I made some modifications. Could you give this a quick read through to make sure I didn't do something objectionable? If everything looks good, I will go ahead and merge today. Many thanks!! |
Member
|
@colinleach - unlocked now. Comment away. Will look at your DM shortly. 😄 |
colinleach
commented
Apr 7, 2026
colinleach
commented
Apr 7, 2026
exercises/practice/dnd-character/.approaches/loop-and-setattr-in-init/content.md
Outdated
Show resolved
Hide resolved
colinleach
commented
Apr 7, 2026
exercises/practice/dnd-character/.approaches/stand-alone-dice-roll-function/content.md
Outdated
Show resolved
Hide resolved
Contributor
Author
|
A few formatting nits, nothing substantive to complain about. |
BethanyG
reviewed
Apr 8, 2026
exercises/practice/dnd-character/.approaches/loop-and-setattr-in-init/content.md
Outdated
Show resolved
Hide resolved
BethanyG
reviewed
Apr 8, 2026
exercises/practice/dnd-character/.approaches/stand-alone-dice-roll-function/content.md
Outdated
Show resolved
Hide resolved
BethanyG
reviewed
Apr 8, 2026
colinleach
commented
Apr 8, 2026
|
|
||
|
|
||
| This approach uses a `tuple` to hold character attributes in a [`class variable`][class-variable] or `class attribute`. | ||
| Since this variable is common to all instances of the class, it can be looped through during object initialization to create instance variables and assign them values using [`setattr][setattr]. |
Contributor
Author
There was a problem hiding this comment.
Nope, [`setattr] is still missing a backtick
Member
|
Many thanks Colin! 💙 Pushing the big, green button! So we'll see all the typos shortly.... 😆 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Something I started long ago but repeatedly got bored with.
It's still boring, but that fits with an exercise that practices many useful things, but as a result is rather bitty and with no grand design to talk about.
Thoughts?