Skip to content

[D&D Character] fix typos in approaches#4122

Merged
BethanyG merged 1 commit intoexercism:mainfrom
colinleach:dnd-typos
Apr 8, 2026
Merged

[D&D Character] fix typos in approaches#4122
BethanyG merged 1 commit intoexercism:mainfrom
colinleach:dnd-typos

Conversation

@colinleach
Copy link
Copy Markdown
Contributor

As you said:

So we'll see all the typos shortly....

This is the first tranche. There seems to be something cursed about setattr.

Where I removed the bit that says (_as is the variant below_) on the last line of that document, I wondered if the whole paragraph is repeated needlessly? Line 78 duplicates line 41.

@BethanyG
Copy link
Copy Markdown
Member

BethanyG commented Apr 8, 2026

Where I removed the bit that says (as is the variant below) on the last line of that document, I wondered if the whole paragraph is repeated needlessly? Line 78 duplicates line 41.

Yes - it is repetitive, but I thought I'd keep the pattern of fully describing each code block. I know for that last one the "big idea" is where to put the ability tuple ... but decided that duplicating the sentence wasn't the end of the world.

Conversely, if you'd like to change the code example to use one of the other non-static method variants, we can then talk about how it follows one of the other approaches. 😄

@colinleach
Copy link
Copy Markdown
Contributor Author

if you'd like to change the code example

I really wouldn't like to do this!

No worries about the repetition. The main point stands: we couldn't have "the variant below" as the last words in the document, where there's no "below".

@BethanyG BethanyG merged commit 35c5616 into exercism:main Apr 8, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants