Fix build fail

Makefile

@@ -153,7 +153,7 @@ build-deb: build-deb-bid-scraper build-deb-rbuilder-operator build-deb-rbuilder-
 .PHONY: lint
 lint: ## Run the linters
 	cargo fmt -- --check
-	cargo clippy --workspace --features "$(FEATURES)" -- -D warnings
+	cargo clippy --workspace --features "$(FEATURES)" --all-targets -- -D warnings
 
 .PHONY: test
 test: ## Run the tests for rbuilder. At reth 1.8.2 we started getting some memory errors (when creating the tmp dbs) so we had to limit the number of threads.
@@ -166,7 +166,7 @@ lt: lint test ## Run "lint" and "test"
 fmt: ## Format the code
 	cargo fmt
 	cargo fix --allow-staged
-	cargo clippy --features "$(FEATURES)" --fix --allow-staged
+	cargo clippy --workspace --features "$(FEATURES)" --all-targets --fix --allow-staged
 
 .PHONY: bench
 bench: ## Run benchmarks

crates/rbuilder/benches/benchmarks/txpool_fetcher.rs

@@ -6,9 +6,10 @@ use alloy_rpc_types::TransactionRequest;
 use alloy_signer_local::PrivateKeySigner;
 use criterion::{criterion_group, Criterion};
 use rbuilder::live_builder::order_input::{
-    txpool_fetcher::subscribe_to_txpool_with_blobs, OrderInputConfig,
+    mempool_txs_detector::MempoolTxsDetector, txpool_fetcher::subscribe_to_txpool_with_blobs,
+    OrderInputConfig,
 };
-use std::time::Duration;
+use std::{sync::Arc, time::Duration};
 use tokio::sync::mpsc;
 use tokio_util::sync::CancellationToken;
 
@@ -22,6 +23,7 @@ async fn txpool_receive_util(count: u32) {
     subscribe_to_txpool_with_blobs(
         OrderInputConfig::default_e2e(),
         sender,
+        Arc::new(MempoolTxsDetector::new()),
         CancellationToken::new(),
     )
     .await

crates/rbuilder/src/building/block_orders/mod.rs

@@ -1,7 +1,5 @@
 mod prioritized_order_store;
 
-#[cfg(test)]
-mod order_dumper;
 pub mod order_priority;
 mod test_data_generator;
 use std::sync::Arc;

crates/rbuilder/src/building/builders/parallel_builder/conflict_task_generator.rs

@@ -3,7 +3,7 @@ use alloy_primitives::{utils::format_ether, U256};
 use crossbeam_queue::SegQueue;
 use itertools::Itertools;
 use rbuilder_primitives::SimulatedOrder;
-use std::{sync::Arc, time::Instant};
+use std::{cmp::Reverse, sync::Arc, time::Instant};
 use tracing::trace;
 
 use super::{
@@ -52,7 +52,7 @@ impl ConflictTaskGenerator {
     /// * `new_groups` - A vector of new [ConflictGroup]s to process.
     pub fn process_groups(&mut self, new_groups: Vec<ConflictGroup>) {
         let mut sorted_groups = new_groups;
-        sorted_groups.sort_by(|a, b| b.orders.len().cmp(&a.orders.len()));
+        sorted_groups.sort_by_key(|b| Reverse(b.orders.len()));
 
         let mut processed_groups = HashSet::default();
         for new_group in sorted_groups {

crates/rbuilder/src/building/builders/parallel_builder/groups.rs

@@ -193,7 +193,7 @@ impl ConflictFinder {
                 let mut code_writes: Vec<Address> = used_state
                     .created_contracts
                     .into_iter()
-                    .chain(used_state.destructed_contracts.into_iter())
+                    .chain(used_state.destructed_contracts)
                     .collect();
                 code_writes.sort_unstable();
                 code_writes.dedup();

crates/rbuilder/src/building/testing/bundle_tests/setup.rs

@@ -212,6 +212,7 @@ impl TestSetup {
             current_value,
         )
     }
+    #[allow(clippy::result_large_err)]
     fn try_commit_order(&mut self) -> eyre::Result<Result<ExecutionResult, ExecutionError>> {
         let state_provider: Arc<dyn StateProvider> =
             Arc::from(self.test_chain.provider_factory().latest()?);

crates/rbuilder/src/live_builder/mod.rs

@@ -371,8 +371,8 @@ where
                 mev_blocker_price,
                 payload
                     .relay_registrations
-                    .iter()
-                    .filter_map(|(_, r)| r.adjustment_fee_payer)
+                    .values()
+                    .filter_map(|r| r.adjustment_fee_payer)
                     .collect(),
                 mempool_detector.clone(),
             ) {

crates/rbuilder/src/utils/receipts.rs

@@ -91,7 +91,7 @@ pub fn calculate_receipts_data(
     }
 
     let mut receipts_with_blooms = Vec::with_capacity(executed_tx_infos.len());
-    for (info, logs_bloom) in executed_tx_infos.iter().zip(receipts_blooms.into_iter()) {
+    for (info, logs_bloom) in executed_tx_infos.iter().zip(receipts_blooms) {
         receipts_with_blooms.push(ReceiptWithBloom {
             receipt: &info.receipt,
             logs_bloom,