fix: correct orchestrator capacity column naming and remove redundant payload capacity columns#225
Open
fix: correct orchestrator capacity column naming and remove redundant payload capacity columns#225
Conversation
… payload capacity columns - Vehicle migration: remove redundant capacity_weight_kg (use existing payload_capacity), rename capacity_volume_m3 → payload_capacity_volume, capacity_pallets → payload_capacity_pallets, capacity_parcels → payload_capacity_parcels to follow Fleetbase naming convention - Payload migration: remove all four redundant capacity columns (capacity_weight_kg, capacity_volume_m3, capacity_pallets, capacity_parcels) — these values are computed dynamically from payload entities, not stored as denormalised cache columns - Vehicle model: update fillable and casts to match renamed columns - Payload model: remove redundant capacity columns from fillable and casts - OrchestrationPayloadBuilder: read payload_capacity (existing column) for vehicle weight capacity; compute job amount array dynamically by aggregating entity weight/dimensions with unit normalisation — no longer reads stale payload capacity cache columns - VehicleController (Api/v1): add payload_capacity, payload_capacity_volume, payload_capacity_pallets, payload_capacity_parcels, skills, max_tasks, time_window_start, time_window_end, return_to_depot to create/update input whitelists - OrderController (Api/v1): add time_window_start, time_window_end, required_skills, orchestrator_priority to create/update input whitelists
…ns for capacity columns - Restore 2026_04_08_000001 and 2026_04_08_000004 to their exact released state; these migrations have already been run on live instances and must not be modified - Add 2026_04_14_000001: drop redundant payload capacity columns (capacity_weight_kg, capacity_volume_m3, capacity_pallets, capacity_parcels) which are now computed dynamically from entities by OrchestrationPayloadBuilder - Add 2026_04_14_000002: rename vehicle capacity columns to follow the payload_capacity_* naming convention and drop the redundant capacity_weight_kg (duplicate of the pre-existing payload_capacity column)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes critical naming inconsistencies and redundant columns introduced with the orchestrator feature in the previous release.
Problems fixed
1. Redundant
capacity_weight_kgon vehicles — duplicates the existingpayload_capacitycolumn. Removed;OrchestrationPayloadBuildernow readspayload_capacitydirectly.2. Non-standard column names on vehicles —
capacity_volume_m3,capacity_pallets,capacity_parcelsrenamed topayload_capacity_volume,payload_capacity_pallets,payload_capacity_parcelsto follow Fleetbase naming convention.3. Redundant capacity columns on payloads — all four payload capacity columns removed entirely;
OrchestrationPayloadBuildernow computes the VROOM jobamountarray dynamically by aggregating entityweight/dimensionswith full unit normalisation (kg, g, lb, oz, t; m, cm, mm, in, ft).4. API controllers did not accept orchestrator fields —
VehicleControllerandOrderControllercreate/updatewhitelists now include all orchestrator constraint and capacity fields.Migration note
Users upgrading from the previous release need to run
php artisan migrateto apply the column renames.