Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the package's export structure by introducing barrel files for various modules and updating the main library file accordingly. It also simplifies imports in the core logic and removes redundant imports in the test suite. Review feedback focused on correcting several typos found in the newly added documentation comments.
packages/genui/lib/genui.dart
Outdated
| /// This library provides the necessary components to build generative user | ||
| /// interfaces in Flutter applications. It includes models for UI components, | ||
| /// data handling, and communication with a generative AI service. | ||
| /// interfaces in Flutter applications. It implements that A2UI protocol |
Contributor
There was a problem hiding this comment.
Typo: 'that' should be 'the'.
/// interfaces in Flutter applications. It implements the A2UI protocol
packages/genui/lib/src/facade.dart
Outdated
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| /// Conventient abstractions for using the GenUI framework. |
Contributor
There was a problem hiding this comment.
Typo: 'Conventient' should be 'Convenient'.
/// Convenient abstractions for using the GenUI framework.
packages/genui/lib/src/facade.dart
Outdated
|
|
||
| /// Conventient abstractions for using the GenUI framework. | ||
| /// | ||
| /// Contains utilities for building GenUI-enabled system promts, and utilities |
Contributor
There was a problem hiding this comment.
Typo: 'promts' should be 'prompts'.
/// Contains utilities for building GenUI-enabled system prompts, and utilities| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| /// String interpolation functions for interpolating string in A2UI payloads. |
Contributor
There was a problem hiding this comment.
Typo: 'string' should be 'strings' for plural agreement.
/// String interpolation functions for interpolating strings in A2UI payloads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #865
Reorganize the export structure of the
genuipackage to improve maintainability, clean up the top-level API surface, and better document the internal library modules.Changes
lib/src/(e.g.,catalog.dart,engine.dart,model.dart, etc.) that encapsulate the internal structure of the package by exporting all files within their respective directories.lib/genui.dart: Updated the main entry point to export these new directory-level libraries instead of listing individual files, significantly simplifying the top-level API.SurfaceAddedandSurfaceRemovedby usinghideclauses when exportingsrc/engine.dartinlib/genui.dart.cf.prefixes informat_string.dartafter resolving imports.unnecessary_importanalysis warnings in multiple test files that were caused by the change in export visibility.lib/genui.dartto explicitly mention the A2UI protocol implementation and support for generative AI services.