Skip to content

Clarify cookbook recipe on when to define a font style#13236

Merged
sfshaza2 merged 2 commits intomainfrom
fix-11581
Mar 31, 2026
Merged

Clarify cookbook recipe on when to define a font style#13236
sfshaza2 merged 2 commits intomainfrom
fix-11581

Conversation

@sfshaza2
Copy link
Copy Markdown
Contributor

@sfshaza2 sfshaza2 commented Mar 31, 2026

Fixes #11581

@sfshaza2 sfshaza2 requested a review from a team as a code owner March 31, 2026 20:29
gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the custom fonts documentation to clarify that Flutter does not infer font weights or styles from filenames and requires explicit declarations in the pubspec.yaml file. The changes also include a typo fix and improved wording regarding how Flutter simulates font styles. A review comment suggests italicizing the word "look" in the bold font section to maintain consistency with the italics section.

justinmc
justinmc approved these changes Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

CC @Piinks who I think reviewed a few google_fonts package PRs recently in case it's relevant (e.g. flutter/packages#11027).

@flutter-website-bot
Copy link
Copy Markdown
Collaborator

flutter-website-bot commented Mar 31, 2026 •
edited
Loading

Visit the preview URL for this PR (updated for commit 3ca4f52):

https://flutter-docs-prod--pr13236-fix-11581-5lz70ykh.web.app

Piinks
Piinks approved these changes Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too! Thanks!

@sfshaza2 sfshaza2 merged commit e28aa61 into main Mar 31, 2026
10 checks passed
@sfshaza2 sfshaza2 deleted the fix-11581 branch March 31, 2026 21:59
sfshaza2 added a commit that referenced this pull request Mar 31, 2026
@sfshaza2
Clarify cookbook recipe on when to define a font style (#13236)
b5f539b 
Fixes #11581
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domesticmouse domesticmouse domesticmouse approved these changes

@justinmc justinmc justinmc approved these changes

@Piinks Piinks Piinks approved these changes

@conooi conooi conooi approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Docs could be clearer on when we should have to define styles

6 participants

@sfshaza2 @flutter-website-bot @domesticmouse @justinmc @Piinks @conooi