Conversation
Workflows set up for `next` to publish to dev, and `main` to publish the versioned docs. `next` will publish when changes are merged, `main` will publish when a tag is created. Other changes made to the configuration file for cleanup and removal of variables that complicated workflow enablement, or served no real purpose. Ran action lint, minor but not breaking issues reported. This commit applies to FFTK-4532, "add dev version" This commit applies to FFTK-4116, "Use GitHub Action…" This commit applies to FFTK-4763, "test workflow…" Signed-off-by: Katrina Prosise <katrina.prosise@foundries.io>
doanac
left a comment
There was a problem hiding this comment.
There's a lot of code that's almost the same. i wonder if they could inherit from a common workflow that was parameterized or something.
However - I also see people go to great lengths to avoid copy/paste where copy/paste would have been a lot easier to deal with in the long run.
I think this is fine to move forward with. I'd actually vote that you eventually take this one step further and move the rest of the remaining docs publishing logic out of lmp-release-tooling and you start handling releases of docs totally from github.
| on: | ||
| push: | ||
| tags: | ||
| - '**' |
There was a problem hiding this comment.
I might change this to be more specific like:
- mp-*
- v*
or something
There was a problem hiding this comment.
I was debating that, keeping in mind potential changes in the future, but yeah, that would allow me to keep things simpler too
Workflows set up for
nextto publish to dev, andmainto publish the versioned docs.nextwill publish when changes are merged,mainwill publish when a tag is created.Other changes made to the configuration file for cleanup and removal of variables that complicated workflow enablement, or served no real purpose.
Ran action lint, minor but not breaking issues reported. Tested over multiple commits, before squashing and opening PR.
This commit applies to FFTK-4532, "add dev version" This commit applies to FFTK-4116, "Use GitHub Action…" This commit applies to FFTK-4763, "test workflow…"
PR Template and Checklist
Please complete as much as possible to speed up the reviewing process.
You may delete items that are not relevant to your contribution.
Readiness and adding reviewers as appropriate is required.
All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.
Readiness
Checklist
make linkcheck, and add redirects for any moved or deleted pages.-s, --signoff).-S, --gpg-sign).Comments
All work has been tested on next