Parse Ntds DnsNode dnsRecord entries#20
Open
william-billaud wants to merge 13 commits intofox-it:mainfrom
Open
Parse Ntds DnsNode dnsRecord entries#20william-billaud wants to merge 13 commits intofox-it:mainfrom
william-billaud wants to merge 13 commits intofox-it:mainfrom
Conversation
4345689 to
7be4506
Compare
Contributor
Author
|
@Schamper just a ping as this PR was previously in draft and I do not now what kind of notification you have, but no emergency on this topic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add function associate with the parsing of DnsNode NTDS entries. Goal is to later include this in a dissect.target plugins.
These entries allow to quickly retrieves DNS record from a Domain. E.g
In terms of review difficulty I would say 3/5 : This PR does not modify existing code, and this feature mainly rely on documented structure unpacking, without difficult concepts to understand and with a good test coverage.
Some note:
Using dissect.cstruct, is it possible to specify that a structure member is in little endian, and other in bug endian (for the same struct, see the swap_endianess function) ?
I have issue with serial number of SOA records, which are not the same as observed in Lab, I can't figure out how MS handle it, I have chosen to not display this value as value is known as being wrong + this is, in my opinion not the most import information.
Not all DNS Record type are parsed. There is a lot of possible structure (27), some of them are nearly never found production env/obsolete or with low interest. But if someone want to, it should be easy to add a missing type.
closes Parse Ntds DnsNode dnsRecord entries #19