fix: disable preview for python challenges#1770
Open
Sembauke wants to merge 1 commit intofreeCodeCamp:mainfrom
Open
fix: disable preview for python challenges#1770Sembauke wants to merge 1 commit intofreeCodeCamp:mainfrom
Sembauke wants to merge 1 commit intofreeCodeCamp:mainfrom
Conversation
Sembauke
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
noPreviewChallengeTypesinChallengeView._panelIconButtons.challengeType != ...checks with a singlecontainscheck.20,23,27,29) do not show the preview toggle.Why
Python challenges do not render project preview the way HTML/CSS/JS challenges do. Some Python challenge types were not excluded, so the preview eye icon appeared unnecessarily.
Root cause
The exclusion guard listed only challenge types
1,26,28, and29, missing Python types20,23, and27.Validation
flutter analyze lib/ui/views/learn/challenge/challenge_view.dart