fix: normalize ssh URL remotes in global discovery#976
Open
officialasishkumar wants to merge 1 commit intogarrytan:mainfrom
Open
fix: normalize ssh URL remotes in global discovery#976officialasishkumar wants to merge 1 commit intogarrytan:mainfrom
officialasishkumar wants to merge 1 commit intogarrytan:mainfrom
Conversation
Handle URL-style SSH git remotes such as ssh://git@github.com/owner/repo.git in the same canonicalization path as scp-style SSH remotes. This prevents global discovery consumers from reporting duplicate repos when different tools or clones use equivalent SSH remote formats. Add regression coverage for GitHub and GitLab URL-style SSH remotes and for deduping SSH URL, scp-style SSH, and HTTPS forms together. Fixes garrytan#975
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ssh://git@host/owner/repo.gitremotes to the same HTTPS canonical form as scp-style SSH remotesFixes #975
Testing
PATH=/tmp/gstack-bun/node_modules/.bin:$PATH bun test test/global-discover.test.tsPATH=/tmp/gstack-bun/node_modules/.bin:$PATH bun -e "import { normalizeRemoteUrl } from './bin/gstack-global-discover.ts'; console.log(normalizeRemoteUrl('git@github.com:garrytan/gstack.git')); console.log(normalizeRemoteUrl('ssh://git@github.com/garrytan/gstack.git')); console.log(normalizeRemoteUrl('https://github.com/garrytan/gstack.git'));"