Open
Conversation
Replaces Trust Wallet Core for TON signing. Adds a Bag-of-Cells implementation (cells/header/raw_cell/indexed_cell/builder/reader/writer), WalletV4R2 transaction assembly, and wires sign_transfer / sign_token_transfer / sign_swap / sign_data on TonChainSigner. Includes parity vectors against the wallet-core deploy test and Android transfer/jetton vectors.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements TON transaction signing by adding a 'Bag of Cells' (BoC) implementation and refactoring the Address struct to use internal byte storage. It also updates gem_encoding with new base64 utilities. TonChainSigner now supports signing for transfers, token transfers, swaps, and generic data. Feedback recommends optimizing the cell indexing algorithm for better performance and removing a redundant string allocation in the fee parsing logic.
Use BigInt::to_biguint() directly instead of parsing a stringified BigInt. Negative values now error explicitly instead of failing the decimal parse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests