docs: add backend selection lookup table#905
docs: add backend selection lookup table#905akihikokuroda merged 1 commit intogenerative-computing:mainfrom
Conversation
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
9ccb632 to
8ff6a0a
Compare
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
8ff6a0a to
79cf9eb
Compare
planetf1
left a comment
There was a problem hiding this comment.
The issue link format fix: #842 won't auto-close on merge — use Closes #842 instead.
planetf1
left a comment
There was a problem hiding this comment.
The five rows are technically accurate (class names, imports, extras, backend_name strings all check out). Two things worth flagging:
The table is organised around start_session() keys, which silently excludes Bedrock — mellea/backends/bedrock.py exists but create_bedrock_mantle_backend() returns an OpenAIBackend with no backend_name equivalent. Similarly, Vertex AI uses LiteLLMBackend but has no row. It would be worth adding a short note below the table explaining that Bedrock and Vertex AI sit outside the start_session() system and linking to their integration pages. The broader LiteLLM docs gaps are tracked in #642.
planetf1
left a comment
There was a problem hiding this comment.
Agree with changes overall - it's reminded me there's more work to do on the docs here such as with litellm (added a note -- one minor comment about adding a footnote for now)
b92cd53
Misc PR
Type of PR
Description
Testing
Attribution