Skip to content

docs: document two session creation patterns#906

Merged
akihikokuroda merged 2 commits intogenerative-computing:mainfrom
akihikokuroda:createsession
Apr 23, 2026
Merged

docs: document two session creation patterns#906
akihikokuroda merged 2 commits intogenerative-computing:mainfrom
akihikokuroda:createsession

Conversation

@akihikokuroda
Copy link
Copy Markdown
Member

@akihikokuroda akihikokuroda commented Apr 22, 2026

Misc PR

Type of PR

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Description

Testing

  • Tests added to the respective file if code was changed
  • New code has 100% coverage if code as added
  • Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)

Attribution

  • AI coding assistants used

Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
@akihikokuroda akihikokuroda requested a review from a team as a code owner April 22, 2026 18:00
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Apr 22, 2026
@github-actions
Copy link
Copy Markdown
Contributor

The PR description has been updated. Please fill out the template for your PR to be reviewed.

Copy link
Copy Markdown
Contributor

@ajbozarth ajbozarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, a few minor suggested edits around readability.

Comment thread README.md Outdated
Comment thread docs/docs/concepts/context-and-sessions.md Outdated
Comment thread docs/docs/concepts/context-and-sessions.md Outdated
Comment thread docs/docs/concepts/context-and-sessions.md Outdated
Signed-off-by: Akihiko Kuroda <akihikokuroda2020@gmail.com>
@akihikokuroda akihikokuroda requested a review from ajbozarth April 22, 2026 23:56
@akihikokuroda akihikokuroda added this pull request to the merge queue Apr 23, 2026
Merged via the queue into generative-computing:main with commit bebf7b1 Apr 23, 2026
7 checks passed
@akihikokuroda akihikokuroda deleted the createsession branch April 23, 2026 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document the two session creation patterns and when to use each

2 participants