Skip to content

fix(wsgi): Respect HTTP_X_FORWARDED_PROTO in request.url construction#5963

Open
sl0thentr0py wants to merge 1 commit intomasterfrom
neel/fix-forward-proto
Open

fix(wsgi): Respect HTTP_X_FORWARDED_PROTO in request.url construction#5963
sl0thentr0py wants to merge 1 commit intomasterfrom
neel/fix-forward-proto

Conversation

@sl0thentr0py
Copy link
Copy Markdown
Member

@sl0thentr0py sl0thentr0py requested a review from a team as a code owner April 8, 2026 14:21
@linear-code
Copy link
Copy Markdown

linear-code bot commented Apr 8, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • (ai) Redact base64 data URLs in image_url content blocks by ericapisani in #5953
  • (integrations) Instrument pyreqwest tracing by servusdei2018 in #5682

Bug Fixes 🐛

  • (wsgi) Respect HTTP_X_FORWARDED_PROTO in request.url construction by sl0thentr0py in #5963

Internal Changes 🔧

  • (openai) Split token counting by API for easier deprecation by ericapisani in #5930
  • (opentelemetry) Ignore mypy error by alexander-alderman-webb in #5927
  • Fix license metadata in setup.py by sl0thentr0py in #5934
  • Update validate-pr workflow by stephanie-anderson in #5931

🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

Codecov Results 📊

142 passed | Total: 142 | Pass Rate: 100% | Execution Time: 22.98s

📊 Comparison with Base Branch

Metric Change
Total Tests 📈 +116
Passed Tests 📈 +116
Failed Tests
Skipped Tests

All tests are passing successfully.

❌ Patch coverage is 6.25%. Project has 13992 uncovered lines.
✅ Project coverage is 33.87%. Comparing base (base) to head (head).

Files with missing lines (2)
File Patch % Lines
wsgi.py 21.80% ⚠️ 104 Missing
_werkzeug.py 14.29% ⚠️ 24 Missing
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    27.26%    33.87%    +6.61%
==========================================
  Files          191       191         —
  Lines        21165     21158        -7
  Branches      6946      6946         —
==========================================
+ Hits          5769      7166     +1397
- Misses       15396     13992     -1404
- Partials       540       700      +160

Generated by Codecov Action

@sl0thentr0py sl0thentr0py force-pushed the neel/fix-forward-proto branch from b751a4f to f515d80 Compare April 8, 2026 14:46
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f515d80. Configure here.

Copy link
Copy Markdown
Member

@ericapisani ericapisani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!



#
def _strip_default_port(host: str, scheme: "Optional[str]") -> str:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Django HTTPS urls are reported as HTTP url behind proxy (ECS + ALB)

2 participants