Skip to content

refactor(ai): Remove gen_ai.tool.type span attribute#5964

Open
ericapisani wants to merge 1 commit intomasterfrom
ep/py-2286-remove-setting-of-tool-type-177
Open

refactor(ai): Remove gen_ai.tool.type span attribute#5964
ericapisani wants to merge 1 commit intomasterfrom
ep/py-2286-remove-setting-of-tool-type-177

Conversation

@ericapisani
Copy link
Copy Markdown
Member

Summary

  • Remove setting of gen_ai.tool.type span data from all AI integrations (openai_agents, pydantic_ai, google_genai)
  • Remove the SPANDATA.GEN_AI_TOOL_TYPE constant
  • Clean up now-unused MCPServer/HAS_MCP imports in pydantic_ai integration

Closes PY-2286

Test plan

  • Linters pass (tox -e linters)
  • mypy passes (tox -e mypy)
  • Integration tests pass for openai_agents, pydantic_ai, google_genai

🤖 Generated with Claude Code

Remove setting of `gen_ai.tool.type` from all AI integrations
(openai_agents, pydantic_ai, google_genai) as this attribute is no
longer needed on the SDK side.

Closes PY-2286

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@linear-code
Copy link
Copy Markdown

linear-code bot commented Apr 8, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • (ai) Redact base64 data URLs in image_url content blocks by ericapisani in #5953
  • (integrations) Instrument pyreqwest tracing by servusdei2018 in #5682

Internal Changes 🔧

  • (ai) Remove gen_ai.tool.type span attribute by ericapisani in #5964
  • (openai) Split token counting by API for easier deprecation by ericapisani in #5930
  • (opentelemetry) Ignore mypy error by alexander-alderman-webb in #5927
  • Fix license metadata in setup.py by sl0thentr0py in #5934
  • Update validate-pr workflow by stephanie-anderson in #5931

🤖 This preview updates automatically when you update the PR.

@ericapisani ericapisani marked this pull request as ready for review April 8, 2026 14:23
@ericapisani ericapisani requested a review from a team as a code owner April 8, 2026 14:23
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

Codecov Results 📊

1852 passed | ⏭️ 317 skipped | Total: 2169 | Pass Rate: 85.38% | Execution Time: 3m 34s

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 12388 uncovered lines.

Files with missing lines (6)
File Patch % Lines
utils.py 0.00% ⚠️ 480 Missing
utils.py 14.04% ⚠️ 98 Missing
tools.py 0.00% ⚠️ 79 Missing
execute_tool.py 0.00% ⚠️ 24 Missing
execute_tool.py 0.00% ⚠️ 21 Missing
consts.py 99.16% ⚠️ 2 Missing

Generated by Codecov Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant