Open
Conversation
Depending on whether other queries depend on this, we may end up moving the exception utility functions to a more central location.
Contributor
Author
|
DCA looks good. Gained 4 results that are likely true positives, and lost 6 false positives (that were in test code anyway). |
Contributor
There was a problem hiding this comment.
Pull request overview
Ports the py/unused-exception-object query to use the newer Python dataflow/call-graph infrastructure (via DataFlowDispatch/ApiGraphs) rather than legacy points-to, aligning the query with the ongoing modernization of Python modeling.
Changes:
- Replaces
LegacyPointsTo-based exception class resolution withDataFlowDispatch+ApiGraphs-based logic. - Adds predicates to recognize exception instantiations for both user-defined exception subclasses and builtin exception classes.
Show a summary per file
| File | Description |
|---|---|
| python/ql/src/Statements/UnusedExceptionObject.ql | Migrates exception-instantiation detection from legacy points-to to the newer dispatch/api-graph based approach. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NB: At a later point, the exception modelling will be consolidated into a submodule of
DataFlowDispatch.