Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Trae integration to be treated as a skills-based agent (agentskills layout) and aligns generated context/documentation paths for Trae.
Changes:
- Convert Trae integration to a
SkillsIntegration, switching output from.trae/rulescommands to.trae/skillsskills layout. - Update Trae context file naming to
.trae/rules/project_rules.mdacross integration scripts and agent-context updaters. - Adjust CLI “next steps” command display to show Trae’s skill invocation style.
Show a summary per file
| File | Description |
|---|---|
| tests/test_agent_config_consistency.py | Updates Trae expectations for skills-based config/registrar behavior. |
| tests/integrations/test_integration_trae.py | Updates Trae integration test constants (currently only context path). |
| src/specify_cli/presets.py | Notes Trae as a native skills agent in preset skill registration comments. |
| src/specify_cli/integrations/trae/scripts/update-context.sh | Updates Trae context filename comment to project_rules.md. |
| src/specify_cli/integrations/trae/scripts/update-context.ps1 | Updates Trae context filename comment to project_rules.md. |
| src/specify_cli/integrations/trae/init.py | Converts Trae to SkillsIntegration and switches commands dir/subdir to skills. |
| src/specify_cli/init.py | Adds Trae to skills-mode display logic for next-steps panel. |
| scripts/powershell/update-agent-context.ps1 | Points Trae context target to .trae/rules/project_rules.md. |
| scripts/bash/update-agent-context.sh | Points Trae context target to .trae/rules/project_rules.md. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comments suppressed due to low confidence (1)
tests/integrations/test_integration_trae.py:12
- TraeIntegration is now a SkillsIntegration (writes speckit-/SKILL.md), but this test still uses MarkdownIntegrationTests and still expects COMMANDS_SUBDIR/REGISTRAR_DIR under
.trae/rules. Update the mixin to SkillsIntegrationTests and align constants with the integration config (commands_subdirskills, registrar dir.trae/skills).
class TestTraeIntegration(MarkdownIntegrationTests):
KEY = "trae"
FOLDER = ".trae/"
COMMANDS_SUBDIR = "rules"
REGISTRAR_DIR = ".trae/rules"
CONTEXT_FILE = ".trae/rules/project_rules.md"
- Files reviewed: 9/9 changed files
- Comments generated: 2
mnriem
left a comment
There was a problem hiding this comment.
Please address Copilot feedback. If not applicable, please explain why
|
@copilot apply changes based on the comments in this thread |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the Trae integration to use a skills-based layout (agentskills.io-style speckit-<name>/SKILL.md) and aligns related configuration, context-file paths, and CLI messaging so Trae behaves like other native skills agents in spec-kit.
Changes:
- Convert
TraeIntegrationto aSkillsIntegrationtargeting.trae/skillswith/SKILL.mdoutputs. - Rename Trae’s agent context target from
.trae/rules/AGENTS.mdto.trae/rules/project_rules.mdacross scripts/tests. - Update “next steps” CLI display logic to show skills invocation syntax for Trae.
Show a summary per file
| File | Description |
|---|---|
| tests/test_agent_config_consistency.py | Updates Trae config expectations to skills (commands_subdir=skills, /SKILL.md). |
| tests/integrations/test_integration_trae.py | Updates Trae integration test expectations for the new context file path (but still needs skills migration updates). |
| src/specify_cli/presets.py | Notes Trae among native skills agents in preset skill registration comments. |
| src/specify_cli/integrations/trae/scripts/update-context.sh | Updates Trae wrapper script comment to point at project_rules.md. |
| src/specify_cli/integrations/trae/scripts/update-context.ps1 | Updates Trae wrapper script comment to point at project_rules.md. |
| src/specify_cli/integrations/trae/init.py | Switches Trae integration to SkillsIntegration and updates dirs/extensions accordingly. |
| src/specify_cli/init.py | Treats Trae as a native skills agent for usage display formatting. |
| scripts/powershell/update-agent-context.ps1 | Updates Trae context file path variable to project_rules.md. |
| scripts/bash/update-agent-context.sh | Updates Trae context file path variable to project_rules.md. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 9/9 changed files
- Comments generated: 4
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the Trae integration to use the skills-based layout (SKILL.md) rather than the prior rules/markdown command layout, aligning Trae with other native skills agents in the CLI.
Changes:
- Switch Trae integration from
MarkdownIntegrationtoSkillsIntegrationand update its directories/config (.trae/skills,/SKILL.md). - Update Trae-related tests to use the shared skills integration test suite and new expected paths.
- Update Trae context file naming to
.trae/rules/project_rules.mdin integration wrappers and shared context update scripts.
Show a summary per file
| File | Description |
|---|---|
| tests/test_agent_config_consistency.py | Updates Trae expectations for commands subdir and skills sentinel extension. |
| tests/integrations/test_integration_trae.py | Switches Trae integration tests to the skills-based test mixin and updates expected paths. |
| src/specify_cli/presets.py | Updates comment to include Trae as a native skills agent. |
| src/specify_cli/integrations/trae/scripts/update-context.sh | Updates Trae context filename in wrapper script header. |
| src/specify_cli/integrations/trae/scripts/update-context.ps1 | Updates Trae context filename in wrapper script header. |
| src/specify_cli/integrations/trae/init.py | Converts Trae integration to SkillsIntegration, updates registrar/config paths, and adds --skills option default. |
| src/specify_cli/init.py | Updates “next steps” display logic to treat Trae as skills-invocation mode. |
| scripts/powershell/update-agent-context.ps1 | Updates Trae context target path to .trae/rules/project_rules.md. |
| scripts/bash/update-agent-context.sh | Updates Trae context target path to .trae/rules/project_rules.md. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 9/9 changed files
- Comments generated: 2
|
Thank you! |
Description
Fixed an issue with the speckit tool's support for the Trae agent. Registered the skpeckit command as skills.
Testing
uv run specify --helpuv sync && uv run pytestAI Disclosure