remove non-target entries leaking into DawnTargets.cmake#63
remove non-target entries leaking into DawnTargets.cmake#63domibel wants to merge 1 commit intogoogle:mainfrom
Conversation
|
👋 Thanks for your contribution! Your PR has been imported to Gerrit. |
|
Hi @kainino0x, I just double checked and the Android monolithic build is still working even with the patch in this PR. are there any public interface (header only) targets that could be missed with this PR? |
|
@meuter Honestly I have no idea. I don't think anyone remembers that much detail about the whole CMake build system. If it works, it works :) |
I am using find_package(Dawn REQUIRED) and got: ``` CMake Error: The link interface of target "dawn::webgpu_dawn" contains: dawn::partition_alloc but the target was not found. ``` DawnTargets.cmake incorrectly includes dawn::partition_alloc since commit 96e9e61 as part of webgpu_dawn's link interface: ```cmake set_target_properties(dawn::webgpu_dawn PROPERTIES INTERFACE_LINK_LIBRARIES "...;dawn::partition_alloc;...") ``` dawn::partition_alloc is a header-only internal target that is never installed, so any downstream find_package(Dawn) fails. This is an imported pull request from #63 GITHUB_PR_HEAD_SHA=e5dc2ff3df350bcf017fd276e3aef50060999f5d ORIGINAL_AUTHOR=Dominique Belhachemi <db@domibel.de> Bug: 441355989 GitOrigin-RevId: 436d507 Change-Id: Ib4103c78461bf4410a964359379eea762be529e0 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/302075 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: James Price <jrprice@google.com> Commit-Queue: James Price <jrprice@google.com>
|
🚀 PR was merged in d0a283a! |
I am using find_package(Dawn REQUIRED) and got:
DawnTargets.cmake incorrectly includes dawn::partition_alloc
since commit 96e9e61 as part of webgpu_dawn's link interface:
dawn::partition_alloc is a header-only internal target that is never
installed, so any downstream find_package(Dawn) fails.