Skip to content

remove non-target entries leaking into DawnTargets.cmake#63

Closed
domibel wants to merge 1 commit intogoogle:mainfrom
domibel:fix/cmake-install-partition-alloc
Closed

remove non-target entries leaking into DawnTargets.cmake#63
domibel wants to merge 1 commit intogoogle:mainfrom
domibel:fix/cmake-install-partition-alloc

Conversation

@domibel
Copy link
Copy Markdown
Contributor

@domibel domibel commented Apr 10, 2026

I am using find_package(Dawn REQUIRED) and got:

CMake Error: The link interface of target "dawn::webgpu_dawn" contains:
  dawn::partition_alloc
but the target was not found.

DawnTargets.cmake incorrectly includes dawn::partition_alloc
since commit 96e9e61 as part of webgpu_dawn's link interface:

set_target_properties(dawn::webgpu_dawn PROPERTIES
  INTERFACE_LINK_LIBRARIES "...;dawn::partition_alloc;...")

dawn::partition_alloc is a header-only internal target that is never
installed, so any downstream find_package(Dawn) fails.

@github-actions
Copy link
Copy Markdown

👋 Thanks for your contribution! Your PR has been imported to Gerrit.
Please visit https://dawn-review.googlesource.com/c/dawn/+/302075 to see it and CC yourself on the change.
After iterating on feedback, please comment on the Gerrit review to notify reviewers.
All reviews are handled within Gerrit, any comments on the GitHub PR may be missed.
You can continue to upload commits to this PR, and they will be automatically imported
into Gerrit.

@kainino0x
Copy link
Copy Markdown
Member

@meuter you added this code in #60, does this change break things for you?

@meuter
Copy link
Copy Markdown
Contributor

meuter commented Apr 11, 2026

Hi @kainino0x, I just double checked and the Android monolithic build is still working even with the patch in this PR. liblog is collected in the other loop here . I guess I was a little too eager when collecting dependencies. I assumed wrongly from this comment that those were public interface targets.

are there any public interface (header only) targets that could be missed with this PR?

@kainino0x
Copy link
Copy Markdown
Member

@meuter Honestly I have no idea. I don't think anyone remembers that much detail about the whole CMake build system. If it works, it works :)

copybara-service bot pushed a commit that referenced this pull request Apr 13, 2026
I am using find_package(Dawn REQUIRED) and got:

```
CMake Error: The link interface of target "dawn::webgpu_dawn" contains:
  dawn::partition_alloc
but the target was not found.
```

DawnTargets.cmake incorrectly includes dawn::partition_alloc
since commit 96e9e61 as part of webgpu_dawn's link interface:

```cmake
set_target_properties(dawn::webgpu_dawn PROPERTIES
  INTERFACE_LINK_LIBRARIES "...;dawn::partition_alloc;...")
```

dawn::partition_alloc is a header-only internal target that is never
installed, so any downstream find_package(Dawn) fails.

This is an imported pull request from
#63

GITHUB_PR_HEAD_SHA=e5dc2ff3df350bcf017fd276e3aef50060999f5d
ORIGINAL_AUTHOR=Dominique Belhachemi <db@domibel.de>

Bug: 441355989
GitOrigin-RevId: 436d507
Change-Id: Ib4103c78461bf4410a964359379eea762be529e0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/302075
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: James Price <jrprice@google.com>
Commit-Queue: James Price <jrprice@google.com>
@github-actions
Copy link
Copy Markdown

🚀 PR was merged in d0a283a!

@github-actions github-actions bot closed this Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants