pcapgo: use %w instead of %v when wrapping errors in WritePacket#1234
Open
alliasgher wants to merge 1 commit intogoogle:masterfrom
Open
pcapgo: use %w instead of %v when wrapping errors in WritePacket#1234alliasgher wants to merge 1 commit intogoogle:masterfrom
alliasgher wants to merge 1 commit intogoogle:masterfrom
Conversation
fmt.Errorf with %v loses the original error, preventing errors.Is and errors.As from matching the underlying cause (e.g. syscall.ENOSPC). Switch to %w so callers can inspect wrapped errors. Fixes google#1213 Signed-off-by: alliasgher <alliasgher123@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1213. Switch from %v to %w in the WritePacket error return so that errors.Is and errors.As can match the underlying system error (e.g. syscall.ENOSPC).