refactor(storage): gaxios migration system test fix#8078
Open
thiyaguk09 wants to merge 10 commits intogoogleapis:storage-node-18from
Open
refactor(storage): gaxios migration system test fix#8078thiyaguk09 wants to merge 10 commits intogoogleapis:storage-node-18from
thiyaguk09 wants to merge 10 commits intogoogleapis:storage-node-18from
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the storage client to use the /storage/v1 API prefix, adds necessary JSON content-type headers, and refactors StorageTransport for improved header handling and Node 18 compatibility. System tests have been updated to skip problematic tests and improve resource cleanup. Review feedback points out a bug in a test's setTimeout implementation that prevents the done callback from being executed, as well as several leftover console.log statements and an unnecessary type cast.
thiyaguk09
added
the
kokoro:force-run
thiyaguk09
force-pushed
the
node18/system-test
branch
from
957daf5 to
70a0132
Compare
thiyaguk09
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕