fix: Upgrade protobufjs and fix legacy key decoding in Datastore

[danieljbruce]

Description

This pull request provides a better fix for what #8071 intends to fix. It resolves the protobufjs dependency issue and it ensures that unit tests don't break.

Impact

1. Resolves security issue
2. Ensures datastore unit tests pass

Testing

Tests have been added to ensure the legacyEncode and legacyDecode functionality remain the same. The only difference will be that with the new src changes, code that used to produce an invalid wire error will now produce a valid output.

Generated notes

Upgrades protobufjs to ^7.5.5 to address security vulnerabilities and fixes a regression in legacy App Engine key decoding. The fix involves calling .setup() on the affected protobuf types to ensure group support is preserved.

---

PR created automatically by Jules for task 16655518185677337093 started by @danieljbruce

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[gemini-code-assist]

Code Review

This pull request updates the protobufjs dependency to version ^7.5.5 and adds explicit initialization for the Reference, Path, and Element types in entity.ts to ensure group support for legacy keys. A review comment suggests refactoring the repetitive type lookups and setup calls into a loop to improve maintainability.

[pearigee]

Can we remove the as any? If possible we should just import and use the correct type.

[danieljbruce]

Yes. It looks like when we remove as any then this works just fine.

[pearigee]

Should this line and below just be its own test? Nesting it's within it's seems needlessly nested for the reader.

Alternatively, you could make a new root describe to group the tests? For example:

const testCases = [...];

describe('decoding keys`, () => {
   testCases.foreEach(tc => {
       it(`should decode "${tc.name}"`, () => {...});
   });
}); 

describe('encoding keys`, () => {
   testCases.foreEach(tc => {
       it(`should ecode "${tc.name}"`, () => {...});
   });
}); 

[danieljbruce]

Good idea. I added a describe block to group the tests. I'm not sure what you mean by nesting it inside it though.

[pearigee]

Before, if I understood correctly, we were doing something like this:

it('root test' () => {
    tests.forEach(t => {
        // Here we have an `it`, inside another `it`.
        it(`child test ${t.name}`, () => {

         });
    })
});

This isn't the convention I have seen in the past. It's common to nest tests in a describe, but not tests in tests.

[danieljbruce]

Added a bit of cleanup.

[danieljbruce]

Yes. It looks like when we remove as any then this works just fine.

[danieljbruce]

Good idea. I added a describe block to group the tests. I'm not sure what you mean by nesting it inside it though.