Skip to content

fix( gapic-generator-typescript): add .boolean() to diregapic and handwritten_layer#8100

Open
quirogas wants to merge 2 commits intogoogleapis:mainfrom
quirogas:fix/gapic-generator-typescript-yargs
Open

fix( gapic-generator-typescript): add .boolean() to diregapic and handwritten_layer#8100
quirogas wants to merge 2 commits intogoogleapis:mainfrom
quirogas:fix/gapic-generator-typescript-yargs

Conversation

@quirogas
Copy link
Copy Markdown
Contributor

This PR fixes a bug in the gapic-generator-typescript CLI wrapper where the diregapic and handwritten_layer flags were not explicitly marked as boolean in the yargs configuration.

Because these flags were missing the .boolean() call, yargs would treat them as requiring a value, causing them to consume the next positional argument (typically the first .proto file path). This led to generation failures or incomplete output when these flags were used via the CLI (e.g., in librarian generate).

Changes

  • Updated core/generator/gapic-generator-typescript/typescript/src/gapic-generator-typescript.ts to add .boolean('diregapic') and .boolean('handwritten_layer').

For #5256

@quirogas quirogas self-assigned this Apr 23, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the GAPIC generator CLI configuration by explicitly marking the diregapic and handwritten_layer flags as boolean types. I have no feedback to provide.

@quirogas quirogas marked this pull request as ready for review April 23, 2026 05:01
@quirogas quirogas requested a review from a team as a code owner April 23, 2026 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant