fix( gapic-generator-typescript): add .boolean() to diregapic and handwritten_layer#8100
Open
quirogas wants to merge 2 commits intogoogleapis:mainfrom
Open
fix( gapic-generator-typescript): add .boolean() to diregapic and handwritten_layer#8100quirogas wants to merge 2 commits intogoogleapis:mainfrom
quirogas wants to merge 2 commits intogoogleapis:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the
gapic-generator-typescriptCLI wrapper where thediregapicandhandwritten_layerflags were not explicitly marked as boolean in theyargsconfiguration.Because these flags were missing the
.boolean()call,yargswould treat them as requiring a value, causing them to consume the next positional argument (typically the first.protofile path). This led to generation failures or incomplete output when these flags were used via the CLI (e.g., in librarian generate).Changes
core/generator/gapic-generator-typescript/typescript/src/gapic-generator-typescript.tsto add.boolean('diregapic')and.boolean('handwritten_layer').For #5256