refactor: decouple ConsistencyRequest from TableAdminRequestContext#2887
Open
jinseopkim0 wants to merge 6 commits intomainfrom
Open
refactor: decouple ConsistencyRequest from TableAdminRequestContext#2887jinseopkim0 wants to merge 6 commits intomainfrom
jinseopkim0 wants to merge 6 commits intomainfrom
Conversation
This commit updates the internal plumbing for `ConsistencyRequest` and `AwaitConsistencyCallable` to support fully qualified table names without breaking the existing public API for the legacy `BigtableTableAdminClient`. b/502616786
product-auto-label
Bot
added
size: m
lqiu96
reviewed
Apr 21, 2026
lqiu96
reviewed
Apr 21, 2026
| Preconditions.checkNotNull(consistencyToken, "consistencyToken must not be null"); | ||
|
|
||
| return new AutoValue_ConsistencyRequest( | ||
| tableName, |
Member
There was a problem hiding this comment.
(just a general question): If this uses the fully qualified name (i assume by the true param), do we need to do any validation to ensure that the input is fully qualified?
What happens if isn't?
lqiu96
reviewed
Apr 21, 2026
| BigtableTableAdminStubSettings settings) throws IOException { | ||
| return new EnhancedBigtableTableAdminStub(settings, ClientContext.create(settings), null); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
nit: Not something that needs to be done in this PR. Thoughts on adding a similar one for the createEnhanced below? I think it would be helpful to help users know when to pick this one vs the other?
e.g. are there certain cases where they don't know the fully qualified TableAdminRequestContext values? Or perhaps don't want it?
lqiu96
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the internal plumbing for
ConsistencyRequestandAwaitConsistencyCallableto support fully qualified table names without breaking the existing public API for the legacyBigtableTableAdminClient.b/502616786