fix: cancel even when vrpc is not started yet and fix newRealCall#2897
Open
mutianf wants to merge 2 commits intogoogleapis:mainfrom
Open
fix: cancel even when vrpc is not started yet and fix newRealCall#2897mutianf wants to merge 2 commits intogoogleapis:mainfrom
mutianf wants to merge 2 commits intogoogleapis:mainfrom
Conversation
product-auto-label
Bot
added
size: m
mutianf
changed the title
Change-Id: I81320830192df0cd16f405487c25b5dcb28985fe
nimf
reviewed
Apr 21, 2026
|
|
||
| if (!status.isOk()) { | ||
| if (!state.compareAndSet(State.STARTED, State.CLOSED)) { | ||
| return; |
Contributor
There was a problem hiding this comment.
The return is missing now. It was here to protect from the race with handleSessionClose, right? Then we should keep it.
Contributor
Author
There was a problem hiding this comment.
it'll now throw an exception if the state is not started. see here: https://github.com/googleapis/java-bigtable/blob/main/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/csm/tracers/DebugTagTracer.java#L27
Contributor
There was a problem hiding this comment.
oh. Do we want a user to have an exception if starting a call coincides with session closing? Am I missing something?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.