build(owlbot): un-final static create methods in Admin Base clients#2898
Open
jinseopkim0 wants to merge 2 commits intomainfrom
Open
build(owlbot): un-final static create methods in Admin Base clients#2898jinseopkim0 wants to merge 2 commits intomainfrom
jinseopkim0 wants to merge 2 commits intomainfrom
Conversation
Updates owlbot.py to programmatically remove the \`final\` modifier from the static \`create\` factory methods in the generated BaseBigtableTableAdminClient and BaseBigtableInstanceAdminClient.
product-auto-label
Bot
added
size: xs
product-auto-label
Bot
added
size: s
blakeli0
reviewed
Apr 21, 2026
| s.replace( | ||
| f"{library}/**/BaseBigtable*AdminClient.java", | ||
| r"public static final BaseBigtable(.*)AdminClient create\(", | ||
| r"public static BaseBigtable\1AdminClient create(" |
Contributor
There was a problem hiding this comment.
Can we remove public as well if they are supposed to be overridden?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates owlbot.py to programmatically remove the `final` modifier from the static `create` factory methods in the generated BaseBigtableTableAdminClient and BaseBigtableInstanceAdminClient.
b/502616786