feat(auth-service): add certified favicon to rendered pages#85
feat(auth-service): add certified favicon to rendered pages#85s-adamantine wants to merge 2 commits intomainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
This PR was not deployed automatically as @s-adamantine does not have access to the Railway project. In order to get automatic PR deploys, please add @s-adamantine to your workspace on Railway. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthroughAdded Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Coverage Report for CI Build 24516337428Coverage remained the same at 32.399%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.changeset/auth-service-favicon.md:
- Line 7: The changeset's Affects line currently reads "**Affects:** End users,
Operators" but must include "Client app developers" and be ordered "End users,
Client app developers, Operators"; update the Affects line in
.changeset/auth-service-favicon.md so it reads "**Affects:** End users, Client
app developers, Operators" to match the required schema.
In `@packages/auth-service/src/routes/recovery.ts`:
- Around line 263-265: renderOtpForm and renderError are missing the
favicon/title snippet added to renderRecoveryForm, causing the icon to disappear
on OTP/error pages; update renderOtpForm and renderError to include the same
head elements you added to renderRecoveryForm (the <link rel="icon" ...>,
<title>Account Recovery</title>, and the style insertion pattern using ${CSS}
and ${renderOptionalStyleTag(opts.customCss)}) so all recovery-related rendered
pages include the favicon and custom CSS consistently.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 4cf0283f-32a2-4120-bcac-10b689d48d93
⛔ Files ignored due to path filters (1)
packages/auth-service/public/favicon.svgis excluded by!**/*.svg
📒 Files selected for processing (6)
.changeset/auth-service-favicon.mdpackages/auth-service/src/routes/account-login.tspackages/auth-service/src/routes/account-settings.tspackages/auth-service/src/routes/choose-handle.tspackages/auth-service/src/routes/login-page.tspackages/auth-service/src/routes/recovery.ts
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Kzoeps
left a comment
Kzoeps
left a comment
There was a problem hiding this comment.
looks good to me, but @aspiers needs to add @s-adamantine to railway members so that this pr is able to run the e2e ( just to be sure )
2 participants
Summary
packages/auth-service/public/favicon.svg(the Certified brand mark) and wires<link rel="icon" href="/static/favicon.svg" type="image/svg+xml">into every rendered<head>: login, recovery, account login (×2), account settings (×3), choose-handle (×2).packages/demo) intentionally not included in this PR.Test plan
pnpm dev:auth, open the hosted login page in a browser, verify the Certified mark appears in the browser tab./static/favicon.svgresponds 200 withimage/svg+xmland no 404s in the dev server log.Linear: HYPER-327
🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Documentation