Refactor: use get_submodule with manual traversal fallback in get_module#1677
Open
yael-shr wants to merge 2 commits intointel:mainfrom
Open
Refactor: use get_submodule with manual traversal fallback in get_module#1677yael-shr wants to merge 2 commits intointel:mainfrom
yael-shr wants to merge 2 commits intointel:mainfrom
Conversation
xin3he
reviewed
Apr 14, 2026
| fallback to manual traversal for backward compatibility. | ||
| """ | ||
| try: | ||
| return module.get_submodule(key) |
Contributor
There was a problem hiding this comment.
Thanks, we had changed it to use get_submodule API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR transitions the
get_modulefunction to use PyTorch's nativeget_submoduleAPI for better performance. It includes a manual traversal fallback to maintain backward compatibility and handle complex paths/regex as discussed in the related issue.Type of Change
Related Issues
Fixes or relates to #1362
Checklist Before Submitting
Note: Refactored a single core function to apply changes globally across 25+ files without cluttering the PR.