Fix: Mismatch between plugin cfg name and its internal name#3334
Merged
Conversation
When generating config scripts (or mapped config files), the dots in plugin names are changed into "@" to avoid the Box dot-parsing functionality. That was not taken into account when comparing config names with skip_config list, resulting in mappings that had no corresponding config files. This simple change fixes that problem Also: updated the platform integration test to use both config deployment methods (scripts and Ansible).
There was a problem hiding this comment.
Pull request overview
Fixes skip_config handling for config items whose internal names use @ (to avoid python-box dot parsing), preventing containerlab config template mappings from being generated for items the user explicitly skipped.
Changes:
- Update containerlab provider config-template filtering to compare
skip_configagainst de-@-ified names. - Update the platform integration topology text and add an explicit per-node
netlab_config_modeoverride entry in the skip-config test topology.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/platform-integration/config/05-skip-config.yml | Updates skip_config platform-integration scenario to exercise intended config deployment behaviors. |
| netsim/providers/clab.py | Fixes skip_config comparison for @-encoded config/template names when building clab.config_templates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When generating config scripts (or mapped config files), the dots in plugin names are changed into "@" to avoid the Box dot-parsing functionality. That was not taken into account when comparing config names with skip_config list, resulting in mappings that had no corresponding config files.
This simple change fixes that problem
Also: updated the platform integration test to use both config deployment methods (scripts and Ansible).