Fix MSVC narrowing-conversion warnings (C4244/C4267) under /W3#1431
Open
benhillis wants to merge 1 commit intojbeder:masterfrom
Open
Fix MSVC narrowing-conversion warnings (C4244/C4267) under /W3#1431benhillis wants to merge 1 commit intojbeder:masterfrom
benhillis wants to merge 1 commit intojbeder:masterfrom
Conversation
Add explicit casts to silence 8 warnings triggered by MSVC /W3: fptostring.cpp: - Add static_cast<int>(precision) where public API (size_t) calls internal template (int) - Add static_cast<int>(...) for pointer-arithmetic result stored in int dragonbox.h: - Add static_cast<uint_least32_t>(n) in umul64() calls inside if-constexpr branches guarded by is_same<UInt, uint_least32_t> to silence MSVC warnings on discarded branches when UInt=uint_least64_t - Change trailing-zero counter 's' from size_t to DecimalExponentType in both remove_trailing_zeros specializations to match exponent type Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
|
Thank you for the contribution. I just wanted to say I have the PR on my mind just not the time yet to check/merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add explicit casts to silence 8 warnings triggered by MSVC /W3:
fptostring.cpp:
dragonbox.h: