Add Postgres database by benthecarman · Pull Request #863 · lightningdevkit/ldk-node

benthecarman · 2026-04-01T19:55:17Z

Add a PostgresStore implementation behind the postgres feature flag, mirroring the existing SqliteStore. Uses tokio-postgres (async-native) with an internal tokio runtime for the sync KVStoreSync trait, following the VssStore pattern.

Also gates sqlite behind a feature flag, since most tests relied on this, we ended up needing to gate a lot of them behind the flag. Curious on thoughts on how to handle this best

ldk-reviews-bot · 2026-04-01T19:55:21Z

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

tnull

Took a first high-level look.

Also gates sqlite behind a feature flag, since most tests relied on this, we ended up needing to gate a lot of them behind the flag. Curious on thoughts on how to handle this best

Not sure I'm following? Why do we want to feature-gate tests based on SQLite?

Also tagging @tankyleo as a secondary reviewer here as he has a lot of recent experience with Postgres on VSS Server.

tnull · 2026-04-02T10:54:07Z

+
+	// An internal runtime we use to avoid any deadlocks we could hit when waiting on async
+	// operations to finish from a sync context.
+	internal_runtime: Option<tokio::runtime::Runtime>,


I think we could avoid using an internal runtime for this and rather just reuse crate::runtime::Runtime, if we wanted. Though, when upstreaming to LDK we'll need to rethink all of this anyways (cf. VssStore upstreaming PR).

Yeah I just copied VSS to be safe.

Yeah, let's drop the extra runtime then.

tnull · 2026-04-02T11:08:45Z


 	/// Builds a [`Node`] instance with a [`SqliteStore`] backend and according to the options
 	/// previously configured.
+	#[cfg(feature = "sqlite")]


Why do we suddenly introduce features? We so far held off and meant to do that in a dedicated PR at some point for this or next release. Is it necessary to make Postgres work?

okay removed for now

Seems the postgres feature is still present in the current version?

benthecarman · 2026-04-03T20:00:49Z

Did fixes in follow up commits for ease of review.

ldk-reviews-bot · 2026-04-04T11:11:09Z

🔔 1st Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot · 2026-04-06T11:12:09Z

🔔 2nd Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tankyleo

Verbose review, please dismiss aggressively :)

benthecarman · 2026-04-08T00:15:57Z

@tankyleo addressed most of your comments. Lots of docs improvements. Better handling around the db name and creating the db. And did the code clean ups + test improvements you suggested.

ldk-reviews-bot · 2026-04-11T15:52:17Z

🔔 1st Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot · 2026-04-13T15:52:53Z

🔔 2nd Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tankyleo

two small nits thank you

Add a PostgresStore implementation behind the "postgres" feature flag, mirroring the existing SqliteStore. Uses tokio-postgres (async-native) with an internal tokio runtime for the sync KVStoreSync trait, following the VssStore pattern. Includes unit tests, integration tests (channel full cycle and node restart), and a CI workflow that runs both against a PostgreSQL service container. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

benthecarman · 2026-04-14T22:47:06Z

two small nits thank you

fixed

ldk-reviews-bot · 2026-04-16T22:41:39Z

🔔 1st Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

ldk-reviews-bot · 2026-04-20T00:00:45Z

🔔 2nd Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tnull · 2026-04-20T09:27:56Z

+		}
+
+		// Default to sslmode=require when TLS is configured
+		if matches!(tls, PgTlsConnector::NativeTls(_)) && config.get_ssl_mode() == SslMode::Prefer {


Claude:

- Silent TLS downgrade. new() only upgrades SslMode::Prefer → Require when tls_config is Some. If a caller passes tls_config=Some(...) but a connection string with sslmode=disable, the connection is plaintext despite having opted into TLS. Consider erroring (or forcing Require) when tls_config.is_some() and sslmode is Disable/Allow. src/io/postgres_store/mod.rs:385.

tnull · 2026-04-20T09:28:18Z

+		);
+
+		// Try connecting to the target database directly — if it exists we're done.
+		let initial_err = match Self::make_config_connection(config, tls).await {


Claude:

- Swallowed initial connect error. create_database_if_not_exists treats any connect failure to the target DB as "DB doesn't exist" (src/io/postgres_store/mod.rs:490). Auth failures, wrong port, etc. fall through to the bootstrap-connect path. The final error message does include initial_err, which is good, but logging it at debug! before swallowing would help diagnose the common "looks like it worked, actually didn't" case.

tnull · 2026-04-20T09:29:17Z

+	/// [`DEFAULT_DB_NAME`](io::postgres_store::DEFAULT_DB_NAME). The database will be created
+	/// automatically if it doesn't already exist. The `connection_string` must not include a
+	/// `dbname` when `db_name` is set, providing both is an error. When auto-creating the
+	/// database if is doesn't exist, the initial connection is made using the default database


Suggested change

/// database if is doesn't exist, the initial connection is made using the default database

/// database if it doesn't exist, the initial connection is made using the default database

tnull · 2026-04-20T09:30:18Z

+		check_namespace_key_validity(primary_namespace, secondary_namespace, Some(key), "read")?;
+
+		let mut locked_client = self.client.lock().await;
+		self.ensure_connected(&mut locked_client).await?;


Calling this on every operation should cost us an extra RTT each time, no?

tnull · 2026-04-20T09:33:52Z

+}
+
+struct PostgresStoreInner {
+	client: tokio::sync::Mutex<Client>,


Rather than just using a single client, can we steal vss-server's SmallPool to not make all operations fully sync and sequenced?

tnull · 2026-04-20T09:35:46Z

+	///
+	/// [PostgreSQL]: https://www.postgresql.org
+	#[cfg(feature = "postgres")]
+	pub fn build_with_postgres_store(


We'll need to add this to ldk_node.udl to actually make this useful in bindings.

tnull · 2026-04-20T09:38:19Z

+			secondary_namespace TEXT NOT NULL DEFAULT '',
+			key TEXT NOT NULL CHECK (key <> ''),
+			value BYTEA,
+			sort_order BIGINT NOT NULL DEFAULT 0 CHECK (sort_order >= 0),


Should we now also follow what we did in lightningdevkit/vss-server#96 and use BIGSERIAL?

Camillarhi · 2026-04-20T19:37:22Z

+	/// The given `db_name` will be used or default to
+	/// [`DEFAULT_DB_NAME`](io::postgres_store::DEFAULT_DB_NAME). The database will be created
+	/// automatically if it doesn't already exist. The `connection_string` must not include a
+	/// `dbname` when `db_name` is set, providing both is an error. When auto-creating the
+	/// database if it doesn't exist, the initial connection is made using the default database
+	/// `postgres`.


Small doc nit, the "initial connection is made using the default database postgres" isn't quite accurate, as the initial connection actually goes to the target database, and postgres is only used as a fallback to create it. Could we reorder this so it reads in the order the code actually runs? The same applies to the ArcedNodeBuilder doc below and PostgresStore::new in postgres_store/mod.rs. Suggested wording:

The given `db_name` will be used or default to [`DEFAULT_DB_NAME`](io::postgres_store::DEFAULT_DB_NAME). The `connection_string` must not include a `dbname` when `db_name` is set, providing both is an error. The database will be created automatically if it doesn't already exist. The initial connection is made to the target database, and if it fails we fall back to the default `postgres` database to create it.

Camillarhi · 2026-04-20T19:59:22Z

+}
+
+struct PostgresStoreInner {
+	client: tokio::sync::Mutex<Client>,


I noticed Mutex<Client> is used here. Since Postgres handles concurrent queries server-side (unlike SQLite), is this intentional for simplicity or to match SqliteStore?

benthecarman requested a review from tnull April 1, 2026 19:55

benthecarman force-pushed the postgres branch from c334535 to 8becefe Compare April 1, 2026 20:12

tnull reviewed Apr 2, 2026

View reviewed changes

tnull requested a review from tankyleo April 2, 2026 11:10

benthecarman added this to Weekly Goals Apr 2, 2026

benthecarman self-assigned this Apr 2, 2026

benthecarman force-pushed the postgres branch 2 times, most recently from b5d297e to e8f478b Compare April 3, 2026 19:57

tankyleo reviewed Apr 7, 2026

View reviewed changes

benthecarman force-pushed the postgres branch 4 times, most recently from a8589ea to a43b13b Compare April 8, 2026 01:08

tankyleo self-requested a review April 9, 2026 15:52

tankyleo reviewed Apr 13, 2026

View reviewed changes

benthecarman force-pushed the postgres branch from a43b13b to a198c18 Compare April 14, 2026 20:21

benthecarman requested a review from tankyleo April 14, 2026 20:22

benthecarman force-pushed the postgres branch from a198c18 to 3c1e82f Compare April 14, 2026 20:34

tankyleo reviewed Apr 14, 2026

View reviewed changes

Comment thread src/builder.rs Outdated

benthecarman force-pushed the postgres branch 2 times, most recently from 3bb9810 to 437f11f Compare April 14, 2026 21:03

tankyleo self-requested a review April 14, 2026 21:42

tankyleo reviewed Apr 14, 2026

View reviewed changes

Comment thread src/builder.rs Outdated

Comment thread src/builder.rs Outdated

Comment thread src/io/postgres_store/mod.rs Outdated

tankyleo requested a review from tnull April 14, 2026 22:40

benthecarman force-pushed the postgres branch from 437f11f to 63b42e5 Compare April 14, 2026 22:46

benthecarman mentioned this pull request Apr 15, 2026

Beta Release lightningdevkit/ldk-server#121

Open

25 tasks

tnull reviewed Apr 20, 2026

View reviewed changes

Camillarhi reviewed Apr 20, 2026

View reviewed changes

	/// database if is doesn't exist, the initial connection is made using the default database
	/// database if it doesn't exist, the initial connection is made using the default database

Conversation

benthecarman commented Apr 1, 2026

Uh oh!

ldk-reviews-bot commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tnull left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

benthecarman commented Apr 3, 2026

Uh oh!

ldk-reviews-bot commented Apr 4, 2026

Uh oh!

ldk-reviews-bot commented Apr 6, 2026

Uh oh!

tankyleo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

benthecarman commented Apr 8, 2026

Uh oh!

ldk-reviews-bot commented Apr 11, 2026

Uh oh!

ldk-reviews-bot commented Apr 13, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tankyleo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

benthecarman commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ldk-reviews-bot commented Apr 16, 2026

Uh oh!

ldk-reviews-bot commented Apr 20, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ldk-reviews-bot commented Apr 1, 2026 •

edited

Loading

benthecarman commented Apr 14, 2026 •

edited

Loading