DRY up batched KVStore reads with semaphore-based BatchingStore#876
Open
tnull wants to merge 1 commit intolightningdevkit:mainfrom
Open
DRY up batched KVStore reads with semaphore-based BatchingStore#876tnull wants to merge 1 commit intolightningdevkit:mainfrom
BatchingStore#876tnull wants to merge 1 commit intolightningdevkit:mainfrom
Conversation
Introduce `BatchingStore`, a `KVStore` wrapper that limits concurrent async I/O via a `tokio::sync::Semaphore`. During initialization the builder wraps the store in `BatchingStore` so all parallel reads share a single concurrency cap, rather than each reader maintaining its own `JoinSet`-based batch queue. Replace the duplicated ~75-line batching loops in `read_payments` and `read_pending_payments` with a generic `read_all_objects<T: Readable>` helper that spawns all reads into a `JoinSet` (relying on the store wrapper for throttling) and collects deserialized results. Both functions become thin one-line delegations. Co-Authored-By: HAL 9000
|
👋 Thanks for assigning @joostjager as a reviewer! |
|
🔔 1st Reminder Hey @joostjager! This PR has been waiting for your review. |
|
🔔 2nd Reminder Hey @joostjager! This PR has been waiting for your review. |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce
BatchingStore, aKVStorewrapper that limits concurrent async I/O via atokio::sync::Semaphore. During initialization the builder wraps the store inBatchingStoreso all parallel reads share a single concurrency cap, rather than each reader maintaining its ownJoinSet-based batch queue.Replace the duplicated ~75-line batching loops in
read_paymentsandread_pending_paymentswith a genericread_all_objects<T: Readable>helper that spawns all reads into aJoinSet(relying on the store wrapper for throttling) and collects deserialized results. Both functions become thin one-line delegations.Co-Authored-By: HAL 9000