expo/overview: Refactor to Use newer/gobject class styles, easing.#13700
Merged
mtwebster merged 2 commits intolinuxmint:masterfrom Apr 18, 2026
Merged
expo/overview: Refactor to Use newer/gobject class styles, easing.#13700mtwebster merged 2 commits intolinuxmint:masterfrom
mtwebster merged 2 commits intolinuxmint:masterfrom
Conversation
1ff4cd5 to
f12d5ba
Compare
JosephMcc
reviewed
Apr 10, 2026
6ad662c to
ef26fa0
Compare
The CinnamonWM class (global.window_manager) has a "destroy" signal which maps to windows being destroyed, not its own class, but this gets caught when using connectObject for signal handling, causing all handlers to be released when the class emits destroy. ClutterActors are really the only thing in Cinnamon's runtime that will have a destroy signal, so just do an instance type check.
ef26fa0 to
4d6d0c4
Compare
- Stop using Lang.bind(). - Use actor easing instead of tweening. - Use actor/widget subclasses instead of this.actor/GenericContainers. - Use connectObject/disconnectObject for signal handling. - Use GLib instead of Mainloop. - Allow early cancel of both modes. - Cleanup rest of codebase's access to overview and expo - Use object vfuncs instead of signal handlers where appropriate.
4d6d0c4 to
76eaa04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.