(WIP) Support for large RPC messages using data streams#1013
Draft
(WIP) Support for large RPC messages using data streams#1013
Conversation
Contributor
ChangesetThe following package versions will be affected by this PR:
|
1egoman
commented
Apr 13, 2026
Comment on lines
+238
to
+253
| // ========================================================================= | ||
| // v2 -> v2 tests (both sides support data streams) | ||
| // ========================================================================= | ||
|
|
||
| /// Spec #1: Caller happy path (short payload) — v2 data stream used. | ||
| #[tokio::test] | ||
| async fn test_v2_v2_caller_happy_path_short() { | ||
| let client = Arc::new(RpcClientManager::new()); | ||
| let transport = Arc::new( | ||
| MockTransport::new() | ||
| .with_remote_protocol("dest", CLIENT_PROTOCOL_DATA_STREAM_RPC), | ||
| ); | ||
|
|
||
| let handle = spawn_perform_rpc( | ||
| client.clone(), | ||
| transport.clone(), |
Contributor
Author
There was a problem hiding this comment.
Note to any reviewers: The tests here don't use the larger e2e test infrastructure in this repository purposely, because some test need to fully emulate the behavior of an old client (ie, doing things like always sending RpcRequest / RpcResponse even with a newer client_protocol, etc).
I am not sure if this is a good idea or not. Halfway through the process, the LLM basically said it couldn't generate the tests with the e2e infrastructure and proposed this as an alternative so I let it go for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is port of the identically named client-sdk-js pull request livekit/client-sdk-js#1832, adding support for RPC protocol version 2, via feeding the spec to a LLM.
Warning
This pull request was LLM generated and has only been lightly reviewed by a human. The author has tested this and confirms it works in the happy path, but no other validation has been done.
A more thorough review of this needs to occur before it could be merged. The plan is to hand this off to a rust sdk maintainer to get it fully across the line.