Fix DisplayProgressBar min_value offset in fill calculation#990
Open
matthewgjohnson wants to merge 1 commit intomathoudebine:mainfrom
Open
Fix DisplayProgressBar min_value offset in fill calculation#990matthewgjohnson wants to merge 1 commit intomathoudebine:mainfrom
matthewgjohnson wants to merge 1 commit intomathoudebine:mainfrom
Conversation
DisplayProgressBar calculated bar_filled_width/height from the raw value rather than the value's offset from min_value. When min_value was 0 (the default), this had no effect — which is why the bug went unnoticed — but any bar with a non-zero minimum rendered the fill incorrectly. DisplayRadialProgressBar already uses the correct form (value - min_value) / (max_value - min_value). Fixes mathoudebine#954
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #954.
DisplayProgressBarcalculated the filled width/height from the raw value rather than the value's offset frommin_value:When
min_valueis 0 (the default), this has no effect — which is why the bug went unnoticed. For any bar with a non-zero minimum (e.g. a temperature bar with min=25, max=95), the fill is wrong:DisplayRadialProgressBaralready uses the correct form ((value - min_value) / (max_value - min_value)).Both the horizontal (
bar_filled_width) and vertical (bar_filled_height) branches had the same bug — both are fixed in this PR.