Add style guide and improve skills#11032
Conversation
|
You've modified Claude Code configuration files. These files contain the shared configuration for all contributors. Please revert this change if unintended. ONLY modify these files if you need to change shared configurations that apply to everyone and have discussed this change with the TW team. To override the Claude settings locally, use For example, if you're changing AWS_PROFILE: Create or edit {
"env": {
"AWS_PROFILE": "your-sandbox-name"
}
} |
MarkvanMents
left a comment
There was a problem hiding this comment.
Looks good.
I have a couple of comments, but nothing that would stop us merging.
| --- | ||
| name: polish | ||
| description: Proofreads documentation and improves clarity, readability, and word choice without changing meaning or reorganizing structure. Simplifies complex sentences, applies style guide standards, and converts passive voice to active voice. Use when the user wants to polish, improve clarity, make more readable, or clean up documentation while preserving its structure. | ||
| description: Proofreads documentation and improves clarity, readability, and word choice without changing meaning or reorganizing structure. Simplifies complex sentences, applies style guide standards, and converts passive voice to active voice. Use when the user wants to polish, improve clarity, make more readable, check style guide compliance, improve language, or clean up documentation while preserving its structure. |
There was a problem hiding this comment.
I wonder whether the order of these matters?
I would probably put "improve clarity" and "improve language" next to each other. Or just say "improve the document"?
| **Polish should**: | ||
| * Read Mendix style guides first (in parallel): `grammar-formatting.md`, `terminology.md`, and `product-naming-guide.md` from `/community-tools/contribute-to-mendix-docs/style-guide/` | ||
| * Fix all spelling, grammar, and punctuation errors | ||
| * Add missing alt text to images (use simple, factual descriptions) |
There was a problem hiding this comment.
Do we expect Claude to be able to read and understand the images.
Do we need an image-reading skill to help find the image and know what to say about it?
There was a problem hiding this comment.
It doesn't actually look at the images, but rather infers based on context what the image probably shows. This tends to be reasonably accurate but it definitely isn't perfect. My feeling is that this is better overall than omitting the alt text parameter, but happy to discuss! Claude has the path to the image, and it can read and analyze the images if directed to—I'm just hesitant to require that as part of this skill because it will make it a fair bit slower and more expensive. It would be a good project for someone to take up though, if someone is interested in making and testing a separate skill (or incorporating it into the in-development accessibility one) with robust alt-text guidelines.
| Then immediately continue: improve clarity and readability without changing meaning, structure, or paragraph order: | ||
| Improve clarity and readability without changing meaning, structure, or paragraph order: | ||
|
|
||
| **Polish should**: |
There was a problem hiding this comment.
Do we need to say not to worry about checking links. Claude seemed very worried about links, but we have htmltest for that which is more reliable and works on the built site.
There was a problem hiding this comment.
I personally find it helpful if Claude keeps an eye out for misformatted link references, and I haven't run into situations where it wastes a lot of time on it. Maybe it's more of an issue if you're looking at multiple pages at once or if you mention links specifically? Let's talk about this more.
| Priority order for determining scope: | ||
| 1. If the user has selected text in a file (check for `ide_selection` tags), only polish the selected text in that file. Don't polish the entire document. | ||
| 2. If there's one open file (check for `ide_opened_file` tags) and no selection, work on the entire file. | ||
| 3. If there are multiple open files, list them and ask which to process. | ||
| 4. If no files are open, ask for a file path. No newline at end of file |
There was a problem hiding this comment.
Nice - hope it works consistently 🙂
There was a problem hiding this comment.
It isn't perfect but it seemed to help a bit. It finds the context a lot better with natural language, like "proofread this file".
| @@ -1,18 +1,17 @@ | |||
| --- | |||
| name: proofread | |||
There was a problem hiding this comment.
Does the style guide not help with proofreading? For example, picking up titles which are not gerunds?
There was a problem hiding this comment.
I think of those as different things—my intent is to have the proofreading skill catch situations where the language is wrong in any context, and those mistakes are clear whether or not the reader is familiar with our style. Then the polish skill focuses on things where the text is wrong because it doesn't match our specific style guidance (voice, tone, formatting, punctuation, terminology, etc). Maybe it's worth reconsidering these skill names to make it more intuitive to understand what they do?
| @@ -0,0 +1,553 @@ | |||
| --- | |||
| title: "Grammar & Formatting" | |||
There was a problem hiding this comment.
I won't review this now. I guess that was a substantial part of what the team did over the past couple of days.
Perhaps I'll do some more investigation and run some tests once it is part of our workflow?
There was a problem hiding this comment.
We did spend a fair bit of time discussing it, but that is not reflected here—this is almost an exact copy of what we have on Confluence (changes are mostly just to reformat it for this context: c7cd89c).
I do think carrying on the work of style guide review/simplification/clarification is an important next step for improving AI output and human comprehension, and so far I'm finding that Olu's app and other AI tools are good ways to identify where the style guide could be clearer.
|
|
||
| These are branded Mendix product names. However, they do not always need "Mendix" in front of them in the documentation. | ||
|
|
||
| ### Apps |
There was a problem hiding this comment.
Do we need to mention that this is only about the Apps part of the Mendix portal. It isn't to be applied whenever the word "app" is used in the plural?
perhaps cross reference term later on
| ## Style Standards | ||
|
|
||
| * **Guiding manual** – Microsoft Writing Style Guide (https://learn.microsoft.com/style-guide/). Apply grammar, inclusive language, terminology, and formatting rules from that document. | ||
| * **Guiding manual** – Mendix-specific style guides (see subsection below) extend and customize the Microsoft Writing Style Guide (https://learn.microsoft.com/style-guide/). Consult the Mendix style guides first for grammar, inclusive language, terminology, and formatting rules; use MSG as fallback for topics not covered by Mendix guides. |
There was a problem hiding this comment.
Do we need to tie MSG to "Microsoft Style Guide" somehow to ensure Claude understands they are the same thing?
Co-authored-by: Mark van Ments <35492184+MarkvanMents@users.noreply.github.com>
|
You've modified Claude Code configuration files. These files contain the shared configuration for all contributors. Please revert this change if unintended. ONLY modify these files if you need to change shared configurations that apply to everyone and have discussed this change with the TW team. To override the Claude settings locally, use For example, if you're changing AWS_PROFILE: Create or edit {
"env": {
"AWS_PROFILE": "your-sandbox-name"
}
} |
|
You've modified Claude Code configuration files. These files contain the shared configuration for all contributors. Please revert this change if unintended. ONLY modify these files if you need to change shared configurations that apply to everyone and have discussed this change with the TW team. To override the Claude settings locally, use For example, if you're changing AWS_PROFILE: Create or edit {
"env": {
"AWS_PROFILE": "your-sandbox-name"
}
} |

Adds Mendix style guide documentation and updates Claude Code configuration to use it.
These changes create a single source of truth for documentation style decisions and enable more consistent automated editing.